Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poison depedency #114

Closed
happysalada opened this issue Apr 21, 2018 · 1 comment
Closed

Poison depedency #114

happysalada opened this issue Apr 21, 2018 · 1 comment

Comments

@happysalada
Copy link

You have a dependency on Poison.
Probably up until now, since Phoenix was using poison, it was working fine. The new Phoenix use Jason. So you will either need to specify the Poison dependency or switch to using Jason.

@scrogson
Copy link
Member

Hi @happysalada,

This library only depends on Poison for tests, but it does set up the JSON serializer to use Poison by default and requires users to pull it in as a dependency.

I have this PR: #92 (which is over 1 year old) which changes the way serializers are registered.

I'll probably consider using Jason instead of Poison before I get around to pulling the trigger on merging it.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants