Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with text highlighting tiptap v1/v2 #1494

Closed
Dinver opened this issue Jun 19, 2021 · 4 comments
Closed

Bug with text highlighting tiptap v1/v2 #1494

Dinver opened this issue Jun 19, 2021 · 4 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@Dinver
Copy link

Dinver commented Jun 19, 2021

Description
When highlighting a word and opening a menu, the entire paragraph is highlighted.

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Mouse double left click
  2. Mouse right click

Current behavior
v1
demo_v1
v2
demo_v2

Expected behavior
demo_normal

Screenshot, video, or GIF
If applicable, add screenshots to help explain your problem.

Environment?
Tested on multiple devices.
Windows 10 x64, FireFox 89.0.1 (64 bit), Google Chrome 91.0.4472.106 (64 bit)

@Dinver Dinver added Type: Bug The issue or pullrequest is related to a bug v2 labels Jun 19, 2021
@pat-son
Copy link

pat-son commented Jun 22, 2021

Seems to only happen when right clicking immediately after the double left click, so there's probably some timeout in the selection code that isn't accounting for the difference between right and left click.

You can reproduce the issue by clicking left, then right, then left again in quick succession.

@philippkuehn
Copy link
Contributor

Since this happens on https://prosemirror.net/ too, I don’t think I can do anything here. Please create an issue at ProseMirror if you think this is an issue.

@Dinver
Copy link
Author

Dinver commented Jun 23, 2021

Since this happens on https://prosemirror.net/ too, I don’t think I can do anything here. Please create an issue at ProseMirror if you think this is an issue.

Thanks for quick response. I created issuse:
ProseMirror/prosemirror#1184
Problem should already be solved.

@philippkuehn
Copy link
Contributor

Thanks! I've released a new tiptap version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants