Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: startOfLine should respect starting in a mark #4330

Open
1 of 2 tasks
daibhin opened this issue Aug 14, 2023 · 0 comments
Open
1 of 2 tasks

[Bug]: startOfLine should respect starting in a mark #4330

daibhin opened this issue Aug 14, 2023 · 0 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@daibhin
Copy link
Contributor

daibhin commented Aug 14, 2023

Which packages did you experience the bug in?

suggestion

What Tiptap version are you using?

2.0.4

What’s the bug you are facing?

The startOfLine attribute in the suggestion package does not account for nodes that are wrapped in a mark. It takes the beginning of the mark as the beginning of the line

Steps to reproduce:

  1. Open the Sandbox
  2. Open the console
  3. Click on the editor within the bolded text
  4. 'RENDERED' is printed to the console

What browser are you using?

Chrome

Code example

https://codesandbox.io/s/peaceful-bush-3zpcx6

What did you expect to happen?

The entire wrapping text is included, not just the text in the mark

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@daibhin daibhin added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Aug 14, 2023
@svenadlung svenadlung changed the title [Bug]: [Bug]: startOfLine should respect starting in a mark Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

3 participants