Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kkc gives incorrect results regarding to the word 令和 #26

Open
xuzhao9 opened this issue Mar 3, 2020 · 2 comments
Open

kkc gives incorrect results regarding to the word 令和 #26

xuzhao9 opened this issue Mar 3, 2020 · 2 comments

Comments

@xuzhao9
Copy link

xuzhao9 commented Mar 3, 2020

For example:

>> れいわ
0: <令/れい><わ/わ>

The correct result should be:
<令和/れいわ>

>> れいわじだい
0: <れ/れ><岩/いわ><時代/じだい>

The correct result should be:
<令和/れいわ><時代/じだい>

I am using libkkc 0.3.5+git20190809.b2e5a15-2.1.

@xuzhao9
Copy link
Author

xuzhao9 commented Mar 3, 2020

This is a bug caused by the frontend fcitx5-kkc, as it failed to load the SKK dictionary.

@xuzhao9 xuzhao9 closed this as completed Mar 3, 2020
@xuzhao9
Copy link
Author

xuzhao9 commented Mar 3, 2020

Some further investigations:
At https://github.com/ueno/libkkc/blob/master/libkkc/context.vala#L174, the context CLEARS the all dictionaries in the context. When the user quits a program, fcitx5-kkc will deconstruct a Context, which clears the dictionary. The next time a program opens, kkc will lose all the dictionary information.

Now the question is: should kkc State keep the dictionary information even though it destructs, and let the caller handle the dictionary resource?

@xuzhao9 xuzhao9 reopened this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant