Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgt_language undefined problem on main #83

Closed
regularfry opened this issue Apr 17, 2024 · 2 comments
Closed

tgt_language undefined problem on main #83

regularfry opened this issue Apr 17, 2024 · 2 comments

Comments

@regularfry
Copy link
Contributor

Looks like there's been a bad merge at some point, or something. This code is currently in whisper_online_server.py:

tokenizer = create_tokenizer(tgt_language)

But the definition of tgt_language has been moved into asr_factory() in whisper_online.py, so that breaks the server startup.

It's a simple fix, and I've done it in #80 here but it might want pulling out to its own patch.

@Gldkslfmsd
Copy link
Collaborator

I'm lost, I hope it's fixed when I merged #80.

@regularfry
Copy link
Contributor Author

Looks like it. If I search for tgt_language I only find it in the asr_factory function so that should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants