Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess unit from calibration #31

Merged
merged 3 commits into from
Aug 28, 2013
Merged

Guess unit from calibration #31

merged 3 commits into from
Aug 28, 2013

Conversation

matze
Copy link
Contributor

@matze matze commented Aug 19, 2013

This change tries to fix #19. For this

  • I added explicit user and device unit fields to calibrations.
  • I added numerator_units() and denominator_units().
  • Renamed to_steps to to_device, because not all devices might have a notion of a step.
  • Removed implicit dropping of units from to_device.

Matthias Vogelgesang added 3 commits August 19, 2013 11:14
Rename to_steps to to_device and do not drop units
8c12e4f 
Final conversion of software device units to whatever the hardware understands
should be done in _set_calibration_position().
Add functions to get numerator/denominator
db73814
Guess unit from calibration to fix #19
417bba9
@matze matze mentioned this pull request Aug 19, 2013
Merged
@tfarago
Copy link
Contributor

tfarago commented Aug 26, 2013

👍

tfarago added a commit that referenced this pull request Aug 28, 2013
@tfarago
Merge pull request #31 from ufo-kit/guess-unit
0967186 
Guess unit from calibration
@tfarago tfarago merged commit 0967186 into master Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter unit from calibration when available
2 participants
@matze @tfarago