Generalize acquisitions #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfarago
force-pushed
the
generalize-acquisitions
branch
from
a521f0c
to
0033d19
Compare
|
Rebased on the fixed master, let's hope the tests pass. |
|
If you could add an example to the docs so that I can hook that up myself in the future without twisting my brains, I'd give you a 👍 |
tfarago
force-pushed
the
generalize-acquisitions
branch
from
0033d19
to
2abd3a0
Compare
which allows for more flexibility for experiments where all the data is taken at once but the download starts later.
tfarago
force-pushed
the
generalize-acquisitions
branch
from
2abd3a0
to
cc96917
Compare
|
I added something to the docs, hope it's fine. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense to split data acquisition and download. Especially when one wants to acquire all the data at once (e.g. fill up a camera buffer with different frame types by external trigger) and worry about the download later.