Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FV3 to better handle data source for regional model LBC processing and combined with #1730 WW3 update #1715

Merged
merged 25 commits into from
May 2, 2023

Conversation

Jili-Dong
Copy link
Contributor

@Jili-Dong Jili-Dong commented Apr 18, 2023

Description

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

rrfs_smoke_conus13km_hrrr_warm
rrfs_smoke_conus13km_hrrr_warm_2threads
rrfs_conus13km_hrrr_warm
rrfs_smoke_conus13km_radar_tten_warm
rrfs_smoke_conus13km_hrrr_warm_debug
rrfs_smoke_conus13km_hrrr_warm_debug_2threads
rrfs_conus13km_hrrr_warm_debug
rrfs_conus13km_hrrr_warm_restart_mismatch

The above tests have incorrect processing of LBC which has been corrected by this PR. A slide has been attached in discussions to explain the difference.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

#1730

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

combined with #1730
Depends on fv3atm#646

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

Related to submodule FV3:

NOAA-EMC/fv3atm#646

It is not expected to change any RT results.

Related to issue:
#1716

JiliDong-NOAA and others added 4 commits April 20, 2023 17:49
Use nccmp to compare netcdf files in regression test on NOAA R&D mach…
@jkbk2004
Copy link
Collaborator

@Jili-Dong There are two urgent PRs on-going this week: #1720 and another PR physics. We need to re-schedule this PR to next week.

@Jili-Dong
Copy link
Contributor Author

@jkbk2004 could you combine this PR with any of the PR you mentioned as this PR is a quite simple one and won't change any baseline

@jkbk2004
Copy link
Collaborator

Since it just needs to point to the cubed sphere branch, the best chance is to combine with next physics PR that we are targeting by Friday. I will keep you posted.

@Jili-Dong
Copy link
Contributor Author

@jkbk2004 sounds good. Thanks

@jkbk2004
Copy link
Collaborator

@jkbk2004
Copy link
Collaborator

@Jili-Dong can you add PR description section? you can copy in the pr template: https://github.com/ufs-community/ufs-weather-model/blob/develop/.github/pull_request_template.md

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 This shows compile_008 still failed on cheyenne.intel. I thought the compile was removed for cheyenne?

Will you try to combine this with #1730 ?

@Jili-Dong
Copy link
Contributor Author

@jkbk2004 PR description section added

@jkbk2004
Copy link
Collaborator

@Jili-Dong can you combine in @MatthewMasarik-NOAA #1730 ww3 branch? Or I may jump in to see if I can directly update your fork. @MatthewMasarik-NOAA if you are still available, can you create a direct pr to Jili's branch?

@Jili-Dong
Copy link
Contributor Author

Jili-Dong commented Apr 28, 2023

@jkbk2004 sure. Let me try combine #1730

@Jili-Dong
Copy link
Contributor Author

@jkbk2004 @MatthewMasarik-NOAA #1730 has been combined with this PR. Please let me know if it looks right.

@jkbk2004
Copy link
Collaborator

@Jili-Dong thanks for following up! can you update pr title to reflect #1730 and add a line to the linked PR section in the description? I will let the tests run over weekend. @BrianCurtis-NOAA I am running on this PR.

@Jili-Dong Jili-Dong changed the title update FV3 to better handle data source for regional model LBC processing update FV3 to better handle data source for regional model LBC processing and combined with #1730 WW3 update Apr 28, 2023
@Jili-Dong
Copy link
Contributor Author

@jkbk2004 updated as requested

@jkbk2004 jkbk2004 added the Baseline Updates Current baselines will be updated. label Apr 30, 2023
@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 1, 2023

@BrianCurtis-NOAA note that rrfs_conus13km_hrrr_warm_restart_mismatch changes as well.

@zach1221
Copy link
Collaborator

zach1221 commented May 1, 2023

Jenkins-ci logs attached. ORTs passed Ok.
ufs-weather-model » ort-docker-pipeline » PR-1715 #1 Console [Jenkins].pdf

@jkbk2004 I can inquire about nccmp with Cheyenne system admin, no problem.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 1, 2023

@BrianCurtis-NOAA skip the test on acorn?

@BrianCurtis-NOAA
Copy link
Collaborator

No, looks to be almost done.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 1, 2023

All tests are done. we can start merging process.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 1, 2023

@Jili-Dong fv3 pr and ww3 pr were merged. Can you update hases and revert change in gitmodules? fv3 hash: NOAA-EMC/fv3atm@832803b ww3 hash: NOAA-EMC/WW3@7c93224

@Jili-Dong
Copy link
Contributor Author

@Jili-Dong fv3 pr and ww3 pr were merged. Can you update hases and revert change in gitmodules? fv3 hash: NOAA-EMC/fv3atm@832803b ww3 hash: NOAA-EMC/WW3@7c93224

@jkbk2004 gitmodules and hashes updated

@jkbk2004 jkbk2004 merged commit 3343326 into ufs-community:develop May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants