Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unstructured WW3 mesh capability to UFS #1727

Merged
merged 43 commits into from
May 15, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 26, 2023

Description

Updates NUOPC cap for WW3 in UFS with capability to use unstructured WW3 meshes. Adds new coupled tests for S2SW utilizing an unstructured WW3 mesh.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Three new input files have been added to input-data-20221101/WW3_input_data_20220624/ on Hera and propagated from there to Orion and Cheyenne. Input data will need to be updated on other platforms when tests are added there.

The added files are:

  • global_270k_with_mom6mask.msh. This is a uniform global mesh of ~270K nodes provided by @aliabdolali
  • ww3_grid.inp.exp.global_270k. This is the input file for creating the mod_def file. It is a copy of the regtests/ww3_ufs1.1/input_unstr/ww3_grid_b.inp file, with the change of the msh file name and using CICE0=CICEN=0.75.
  • mesh.global_270k.nc. This is the ESMF mesh file required by the cap. It is created using the SCRIP file produced by the mod_def creation. This is only ESMF mesh file created using the SCRIP file created by WW3 itself. For the mesh creation for other supported applications, see the UFS-WM user's guide

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

New baselines are required for the unstructured WW3 tests which are being added for the S2SW app. Otherwise no existing baseline will change. New tests will initially be only on orion, hera.intel+gnu, cheyenne.intel+gnu

RegressionTests_hera.gnu.log
RegressionTests_hera.intel.log

On hera.intel:

FAILED TESTS:
Test cpld_control_pdlib_p8 024 failed in check_result failed
Test cpld_control_pdlib_p8 024 failed in run_test failed
Test cpld_debug_pdlib_p8 027 failed in run_test failed

On hera.gnu:

FAILED TESTS:
Test cpld_control_pdlib_p8 054 failed in check_result failed
Test cpld_control_pdlib_p8 054 failed in run_test failed
Test cpld_debug_pdlib_p8 055 failed in check_result failed
Test cpld_debug_pdlib_p8 055 failed in run_test failed

The cpld_debug_pdlib_p8 test timed out on hera.intel. Resources have been added increased for this test.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DeniseWorthen DeniseWorthen changed the title Feature/add unstr Add Unstructured WW3 mesh capability to UFS Apr 26, 2023
@DeniseWorthen DeniseWorthen added New Input Data Req'd This PR requires new data to be sync across platforms Baseline Updates Current baselines will be updated. labels Apr 26, 2023
@DeniseWorthen DeniseWorthen marked this pull request as ready for review May 2, 2023 13:55
@aliabdolali
Copy link
Collaborator

@DeniseWorthen this is what I have been waiting for a long time. Thanks for nailing down all the problems we could not fix from WW3 side.

@epic-cicd-jenkins
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1329282628/20230515072218/ufs-weather-model
[RT] Error: Test cpld_control_p8_mixedmode 001 failed in run_test failed
[RT] Error: Test cpld_control_gfsv17 002 failed in run_test failed
[RT] Error: Test cpld_control_p8 003 failed in run_test failed
[RT] Error: Test cpld_control_qr_p8 005 failed in run_test failed
[RT] Error: Test cpld_2threads_p8 007 failed in run_test failed
[RT] Error: Test cpld_decomp_p8 008 failed in run_test failed
[RT] Error: Test cpld_mpi_p8 009 failed in run_test failed
[RT] Error: Test cpld_control_ciceC_p8 010 failed in run_test failed
[RT] Error: Test cpld_control_c192_p8 011 failed in run_test failed
[RT] Error: Test cpld_control_nowave_noaero_p8 014 failed in run_test failed
[RT] Error: Test cpld_control_c48 018 failed in run_test failed
[RT] Error: Test cpld_control_pdlib_p8 021 failed in run_test failed
[RT] Error: Test cpld_debug_pdlib_p8 024 failed in run_test failed
[RT] Error: Test control_c192 031 failed in run_test failed
[RT] Error: Test control_c384 032 failed in run_test failed
[RT] Error: Test control_c384gdas 033 failed in run_test failed
[RT] Error: Test control_restart_qr_p8 042 failed in run_test failed
[RT] Error: Test regional_restart 050 failed in run_test failed
[RT] Error: Test regional_restart_qr 052 failed in run_test failed
[RT] Error: Test regional_2dwrtdecomp 057 failed in run_test failed
[RT] Error: Test regional_wofs 058 failed in run_test failed
[RT] Error: Test rap_control 059 failed in run_test failed
[RT] Error: Test regional_spp_sppt_shum_skeb 060 failed in run_test failed
[RT] Error: Test rap_decomp 061 failed in run_test failed
[RT] Error: Test rap_2threads 062 failed in run_test failed
[RT] Error: Test rap_sfcdiff 064 failed in run_test failed
[RT] Error: Test rap_sfcdiff_decomp 065 failed in run_test failed
[RT] Error: Test hrrr_control 067 failed in run_test failed
[RT] Error: Test hrrr_control_decomp 068 failed in run_test failed
[RT] Error: Test hrrr_control_2threads 069 failed in run_test failed
[RT] Error: Test rrfs_v1beta 071 failed in run_test failed
[RT] Error: Test rrfs_v1nssl 072 failed in run_test failed
[RT] Error: Test rrfs_v1nssl_nohailnoccn 073 failed in run_test failed
[RT] Error: Test rrfs_smoke_conus13km_hrrr_warm 074 failed in run_test failed
[RT] Error: Test rrfs_smoke_conus13km_hrrr_warm_2threads 075 failed in run_test failed
[RT] Error: Test rrfs_conus13km_hrrr_warm 076 failed in run_test failed
[RT] Error: Test rrfs_smoke_conus13km_radar_tten_warm 077 failed in run_test failed
[RT] Error: Test control_csawmg 079 failed in run_test failed
[RT] Error: Test control_csawmgt 080 failed in run_test failed
[RT] Error: Test control_ras 081 failed in run_test failed
[RT] Error: Test rrfs_smoke_conus13km_hrrr_warm_debug 085 failed in run_test failed
[RT] Error: Test rrfs_smoke_conus13km_hrrr_warm_debug_2threads 086 failed in run_test failed
[RT] Error: Test rrfs_conus13km_hrrr_warm_debug 087 failed in run_test failed
[RT] Error: Test control_CubedSphereGrid_debug 088 failed in run_test failed
[RT] Error: Test control_wrtGauss_netcdf_parallel_debug 089 failed in run_test failed
[RT] Error: Test control_stochy_debug 090 failed in run_test failed
[RT] Error: Test control_lndp_debug 091 failed in run_test failed
[RT] Error: Test control_csawmg_debug 092 failed in run_test failed
[RT] Error: Test control_csawmgt_debug 093 failed in run_test failed
[RT] Error: Test control_ras_debug 094 failed in run_test failed
[RT] Error: Test control_diag_debug 095 failed in run_test failed
[RT] Error: Test control_debug_p8 096 failed in run_test failed
[RT] Error: Test regional_debug 097 failed in run_test failed
[RT] Error: Test rap_control_debug 098 failed in run_test failed
[RT] Error: Test hrrr_control_debug 099 failed in run_test failed
[RT] Error: Test rap_unified_drag_suite_debug 100 failed in run_test failed
[RT] Error: Test rap_diag_debug 101 failed in run_test failed
[RT] Error: Test rap_cires_ugwp_debug 102 failed in run_test failed
[RT] Error: Test rap_unified_ugwp_debug 103 failed in run_test failed
[RT] Error: Test rap_lndp_debug 104 failed in run_test failed
[RT] Error: Test rap_progcld_thompson_debug 105 failed in run_test failed
[RT] Error: Test rap_noah_debug 106 failed in run_test failed
[RT] Error: Test rap_sfcdiff_debug 107 failed in run_test failed
[RT] Error: Test rap_noah_sfcdiff_cires_ugwp_debug 108 failed in run_test failed
[RT] Error: Test rrfs_v1beta_debug 109 failed in run_test failed
[RT] Error: Test rap_clm_lake_debug 110 failed in run_test failed
[RT] Error: Test rap_flake_debug 111 failed in run_test failed
[RT] Error: Test regional_atmaq 166 failed in run_test failed
[RT] Error: Test regional_atmaq_faster 167 failed in run_test failed
[RT] Error: Test compile_014 failed in run_compile failed
[RT] Error: Test compile_017 failed in run_compile failed
[RT] Error: Test compile_018 failed in run_compile failed
[RT] Error: Test compile_019 failed in run_compile failed
[RT] Error: Test compile_020 failed in run_compile failed
[RT] Error: Test compile_021 failed in run_compile failed
[RT] Error: Test compile_022 failed in run_compile failed
[RT] Error: Test compile_023 failed in run_compile failed
[RT] Error: Test compile_024 failed in run_compile failed
[RT] Error: Test compile_025 failed in run_compile failed
[RT] Error: Test compile_026 failed in run_compile failed
[RT] Error: Test compile_027 failed in run_compile failed
[RT] Error: Test compile_028 failed in run_compile failed
[RT] Error: Test compile_029 failed in run_compile failed
[RT] Error: Test compile_030 failed in run_compile failed
[RT] Error: Test compile_031 failed in run_compile failed
[RT] Error: Test compile_032 failed in run_compile failed
[RT] Error: Test compile_034 failed in run_compile failed
Please make changes and add the following label back: cheyenne-intel-RT

@jkbk2004
Copy link
Collaborator

I manually push cheyenne.intel log ok. Please, ignore cheyenne intel failure report: jenkins issue.

@jkbk2004
Copy link
Collaborator

All the tests are done. We can start merging process.

@JessicaMeixner-NOAA
Copy link
Collaborator

WW3 has been merged: NOAA-EMC/WW3@c4b1168

Thank you again to @DeniseWorthen for this and all of the debugging that came before it. It's great work, it will be used by so many and is really appreciated.

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super exciting to add in the unstructured mesh! Thank you @DeniseWorthen.

@jkbk2004 jkbk2004 self-requested a review May 15, 2023 17:16
@jkbk2004 jkbk2004 merged commit e403bb4 into ufs-community:develop May 15, 2023
@aliabdolali
Copy link
Collaborator

I am glad my legacy has got into the coupled application, awesome Denise, you linked ww3 unstr to ufs-weather-model, hope we see more use of ww3 unstr in coupled applications.

@junwang-noaa
Copy link
Collaborator

Thanks Ali for the work. Also special thanks to Denise for working so hard on the WW3 unstructured grid capability!

@aliabdolali
Copy link
Collaborator

@junwang-noaa this is always rewarding to see the use of your work in multiple places, I think what @DeniseWorthen did it here leveraged the work and we will definitely see enhancements in the coupled model due to the use of WW3 unstructured (if used properly). Hopefully less complaints about WW3😉 this is a different model

@AvichalMehra-NOAA
Copy link

AvichalMehra-NOAA commented May 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container New Input Data Req'd This PR requires new data to be sync across platforms Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet