Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SW net to ocean #1773

Merged
merged 76 commits into from
Aug 25, 2023
Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented May 31, 2023

Description

Implements the ocean albedo calculation in CMEPS to determine SWnet sent to ocean.

A configuration variable (ocean_albedo_limit) is added to the mediator attributes and set = 0.06 in order to match the behaviour of FV3 (see ccpp/physics/physics/GFS_surface_generic_post.F90).

Two additional configuration variables (flux_albav = true, albdir = 0.06) can be used to mimic the current treatement of SW net to the ocean even with the use of the mediator ocean albedo calculation.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

RegressionTests_hera.log

All global DATM and Coupled RTs will need new baselines. HAFS baselines do not change since the HAFS application uses SWnet from the ATM. The atmwav_control_noaero_p8_intel reproduces all files except for the WAV restart file.

Failed tests
139:Test 001 cpld_control_p8_mixedmode_intel FAIL
210:Test 002 cpld_control_gfsv17_intel FAIL
282:Test 003 cpld_control_p8_intel FAIL
354:Test 005 cpld_control_qr_p8_intel FAIL
414:Test 007 cpld_2threads_p8_intel FAIL
474:Test 008 cpld_decomp_p8_intel FAIL
534:Test 009 cpld_mpi_p8_intel FAIL
606:Test 010 cpld_control_ciceC_p8_intel FAIL
666:Test 011 cpld_control_c192_p8_intel FAIL
721:Test 013 cpld_bmark_p8_intel FAIL
792:Test 015 cpld_control_noaero_p8_intel FAIL
861:Test 016 cpld_control_nowave_noaero_p8_intel FAIL
921:Test 017 cpld_debug_p8_intel FAIL
980:Test 018 cpld_debug_noaero_p8_intel FAIL
1049:Test 019 cpld_control_noaero_p8_agrid_intel FAIL
1106:Test 020 cpld_control_c48_intel FAIL
1178:Test 021 cpld_control_p8_faster_intel FAIL
1249:Test 022 cpld_control_pdlib_p8_intel FAIL
1308:Test 025 cpld_debug_pdlib_p8_intel FAIL
4901:Test 158 datm_cdeps_control_cfsr_intel FAIL
4914:Test 160 datm_cdeps_control_gefs_intel FAIL
4927:Test 161 datm_cdeps_iau_gefs_intel FAIL
4940:Test 162 datm_cdeps_stochy_gefs_intel FAIL
4953:Test 163 datm_cdeps_ciceC_cfsr_intel FAIL
4966:Test 164 datm_cdeps_bulk_cfsr_intel FAIL
4979:Test 165 datm_cdeps_bulk_gefs_intel FAIL
4995:Test 166 datm_cdeps_mx025_cfsr_intel FAIL
5011:Test 167 datm_cdeps_mx025_gefs_intel FAIL
5022:Test 168 datm_cdeps_multiple_files_cfsr_intel FAIL
5035:Test 169 datm_cdeps_3072x1536_cfsr_intel FAIL
5048:Test 170 datm_cdeps_gfs_intel FAIL
5061:Test 171 datm_cdeps_debug_cfsr_intel FAIL
5074:Test 172 datm_cdeps_control_cfsr_faster_intel FAIL
5248:Test 176 atmwav_control_noaero_p8_intel FAIL
7330:Test 244 cpld_control_p8_gnu FAIL
7399:Test 245 cpld_control_nowave_noaero_p8_gnu FAIL
7459:Test 246 cpld_debug_p8_gnu FAIL
7530:Test 247 cpld_control_pdlib_p8_gnu FAIL
7589:Test 248 cpld_debug_pdlib_p8_gnu FAIL
7602:Test 249 datm_cdeps_control_cfsr_gnu FAIL

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

DeniseWorthen and others added 30 commits January 18, 2023 08:44
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
update cmeps build to implement check4nans feature using module stored in cdeps repo
@DeniseWorthen DeniseWorthen added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Aug 21, 2023
junwang-noaa
junwang-noaa previously approved these changes Aug 24, 2023
@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Aug 24, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Jenkins ci logs are attached, apologies for the delay Jenkins had to be rerun on this PR due an issue with staging the test data, should be resolved now.
ufs-weather-model » ort-docker-pipeline » PR-1773#1 Console [Jenkins].txt

Copy link
Collaborator

@jiandewang jiandewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve based on previous 8 mini testing results and today's RT test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SW net to ocean is too large at low sun angles
7 participants