Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary cmake options files for Gaea C5, Derecho, Hercules to support SRW runs #1900

Conversation

natalie-perlin
Copy link
Collaborator

@natalie-perlin natalie-perlin commented Sep 12, 2023

PR Author Checklist:

Description

This PR adds preliminary cmake configurations for new platforms Gaea, Derecho, Hercules. It will enable for the UFS-SRW to use and test these platforms for Atmospheric-only runs, while testing of UFS WM supporting all of its components is still undergoing.
SRW fundamental tests were successfully run on Derecho and Gaea C5.

Linked Issues and Pull Requests

This addresses issues:
ufs-community/ufs-srweather-app#884
ufs-community/ufs-srweather-app#885
ufs-community/ufs-srweather-app#886

Dependencies:
ufs-community/ufs-srweather-app#894
ufs-community/ufs-srweather-app#898
ufs-community/ufs-srweather-app#911 (Still work-in-progress)

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • none

Anticipated Changes

Input data

  • No changes are expected to input data.

Regression Tests:

  • No changes are expected to any regression test.

Libraries

  • Not Needed
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@natalie-perlin natalie-perlin changed the title Preliminary cmake options files for Gaea C5, Derecho, Hercules Preliminary cmake options files for Gaea C5, Derecho, Hercules to support SRW runs Sep 13, 2023
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@natalie-perlin
Copy link
Collaborator Author

@DavidHuber-NOAA - could it be approved?

@DavidHuber-NOAA
Copy link
Collaborator

@natalie-perlin Yes, I did approve it. However, I'm not a code manager, so you will need an additional code manager approval for this to be mergeable.

@jkbk2004
Copy link
Collaborator

We will coordinate to combine with existing PRs. @natalie-perlin do you have timeline ?

@junwang-noaa
Copy link
Collaborator

Did someone run UFS WM full RT with these updates? The description only mentioned SRW fundamental tests.

@jkbk2004
Copy link
Collaborator

This PR should be combined to #1773, #1784, #1836.

@DusanJovic-NOAA
Copy link
Collaborator

Why is AVX2 set to ON in gaea_c5 file, it is a default, no need to set it again. My understanding is that gaea C5 is similar to WCOSS2 and on WCOSS2 we were told to not use AVX2 option. Similar recommendation was also given for C5.

I do not see anything specific to SRW in this PR. Please remove "to support SRW runs" from the PR title. Why are these changes preliminary?

@natalie-perlin
Copy link
Collaborator Author

@DusanJovic-NOAA - after coordinating with Gaea C5 team, they confirmed that it could be OK to use AVX2 on Gaea C5 if this works for the code (as per @ulmononian ) and generates no issues. Testing have not been done with the other components of the UFS besides the FV3.

@junwang-noaa , @jkbk2004 -

These features only related to the SRW: this would allow UFS-WM to be checked out and have these cmake options already available for buildding and running the SRW tests and workflow.

If this is not a desired behavior, and could only be merged with #1784 , #1836 , there is no reason to keep this PR, as it has no purpose. Closing it.

@junwang-noaa
Copy link
Collaborator

@natalie-perlin My understanding is that we are trying to get reproducible results between gaea c5 and wcoss2, is there any special request that we don't maintain that capability any more?

The previous procedure for a new platform is that the common features such as the module file update should be applied to all the applications to avoid code diverge. Does EPIC have a different procedure now on how to port the ufs weather model to new platform for all the applications? If yes, would you please let us know how to take care other applications and how to maintain the shared module files? Thanks

@natalie-perlin
Copy link
Collaborator Author

@junwang-noaa -
Thank you for your comment! I proceeded with testing the SRW on Gaea C5 without these specific cmake options, and it seems to be working successfully. If this is indeed anticipated, SRW testing could proceed with only SRW modulefiles changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants