Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic 3D instantaneous cloud fractions added. #181

Merged
merged 14 commits into from
Aug 21, 2020
Merged

Diagnostic 3D instantaneous cloud fractions added. #181

merged 14 commits into from
Aug 21, 2020

Conversation

ericaligo-NOAA
Copy link
Collaborator

@ericaligo-NOAA ericaligo-NOAA commented Aug 6, 2020

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Diagnostic cldfra array outputs 3D instantaneous cloud fractions. Works with WSM6, Thompson and GFDL mp schemes. No results changed.

UPDATE: Provided a bug fix to GFS_restart.F90 with an if condition added in the ifdef CCPP block to test for reflectivity flag. RTs have been updated. Test run in 3-km FV3 LAM was successful and plots looked good.

Issue(s) addressed

#158
NOAA-EMC/fv3atm#154
NCAR/ccpp-physics#484

Testing

How were these changes tested?
Tested on hera with the SAR configuration. Evaluated fields from run with Thompson microphyics and GFDL microphysics.
Full RTs performed on hera.

Dependencies

FV3
ccpp/physics

@ericaligo-NOAA ericaligo-NOAA changed the title Cldfra Diagnostic 3D instantaneous cloud fractions added. Aug 6, 2020
@junwang-noaa
Copy link
Collaborator

Eric,

Would you please answer the questions in the PR template? Please describe what this PR is going to do, then the issue created on ufs-weathermodel, have you done any kind of testing? If there are any other subcomponnet PRs associated with this PR?

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Aug 6, 2020 via email

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Aug 6, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Aug 6, 2020 via email

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Aug 6, 2020 via email

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Aug 6, 2020 via email

@DusanJovic-NOAA
Copy link
Collaborator

Thanks.  Do I  need to git commit any log files?

On 8/6/2020 2:13 PM, Jun Wang wrote: The command is: ./rt.sh -fe rt.conf Also please list and link the fv3 and ccpp PR number (like you did for issue number) On Thu, Aug 6, 2020 at 2:00 PM ericaligo-NOAA @.***> wrote: > I didn't run all of the RTs on hera. If you need me to do that please > remind me of the command to do this in the /tests directory. Is it > rt.sh -k *****, where I'm not sure what the **** would be. Then let me > know if I would need to git add and commit the log files and push them > to my branch. I can't recall all of those details. Also in the past, I > only needed to do that on hera. > > Eric > > On 8/6/2020 1:37 PM, Jun Wang wrote: > > > > Eric, > > > > Would you please answer the questions in the PR template? Please > > describe what this PR is going to do, then the issue created on > > ufs-weathermodel, have you done any kind of testing? If there are any > > other subcomponnet PRs associated with this PR? > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > < > #181 (comment)>, > > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA > >. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#181 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#181 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQ75MJT4ZLQX2S2AYY2GNTR7LXDHANCNFSM4PWZOUBA.

Not yet. If you do, you'll get merge conflict later when you merge your branch with develop. You can attach log from Hera to this PR if you want.

@DusanJovic-NOAA
Copy link
Collaborator

I see a bunch of errors immediately: + ecflow_client --ping --host=hfe08 --port=3827 [18:15:40 6.8.2020] Request( --ping :Eric.Aligo@hfe08 ), Failed to connect to hfe08:3827. A fter 2 attempts. Is the server running ? + not_running=1 + [[ 1 -eq 1 ]] + echo 'ecflow_server is NOT running on hfe08:3827' ecflow_server is NOT running on hfe08:3827 + sh /scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh -p 3827 [18:15:42 6.8.2020] Request( --ping :Eric.Aligo@hfe08 ), Failed to connect to hfe08:3827. A fter 2 attempts. Is the server running ? grep: /home/Eric.Aligo/.ecflowrc/servers: No such file or directory grep: /home/Eric.Aligo/.ecflow_ui/servers.txt: No such file or directory /scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh: line 188: /home/Eric.Alig o/.ecflow_ui/servers.txt: No such file or directory

On 8/6/2020 2:13 PM, Jun Wang wrote: The command is: ./rt.sh -fe rt.conf Also please list and link the fv3 and ccpp PR number (like you did for issue number) On Thu, Aug 6, 2020 at 2:00 PM ericaligo-NOAA @.***> wrote: > I didn't run all of the RTs on hera. If you need me to do that please > remind me of the command to do this in the /tests directory. Is it > rt.sh -k *****, where I'm not sure what the **** would be. Then let me > know if I would need to git add and commit the log files and push them > to my branch. I can't recall all of those details. Also in the past, I > only needed to do that on hera. > > Eric > > On 8/6/2020 1:37 PM, Jun Wang wrote: > > > > Eric, > > > > Would you please answer the questions in the PR template? Please > > describe what this PR is going to do, then the issue created on > > ufs-weathermodel, have you done any kind of testing? If there are any > > other subcomponnet PRs associated with this PR? > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > < > #181 (comment)>, > > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA > >. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#181 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#181 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQ75MJT4ZLQX2S2AYY2GNTR7LXDHANCNFSM4PWZOUBA.

This is because it's the first time you are running ecflow on this host. The regression test script should continue to run.

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Aug 6, 2020 via email

@MinsukJi-NOAA
Copy link
Contributor

Were compiles successful? When compile fails, all runs are automatically aborted by ecflow. Check to see if you have *.exe files in the ufs-weather-model/tests directory.

.gitmodules Outdated
@@ -1,6 +1,6 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
url = https://github.com/NOAA-EMC/fv3atm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the space

@DusanJovic-NOAA DusanJovic-NOAA merged commit 20f639c into ufs-community:develop Aug 21, 2020
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants