Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean to inst field names, part I #1925

Merged
merged 142 commits into from
Oct 10, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 27, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Changes some field names going TO ATM from CICE or CMEPS to remove "mean" prefix. Also renames the FV3 export fields prec,fprec and prec_rate_conv as inst rather than mean.

This is the first part of a 2 part commit sequence to change from mean->inst field names. This first part will not change baselines against those created using the second of the two dependent PRs.

Logs will be posted once the dependent PRs have been merged.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

DeniseWorthen and others added 30 commits January 18, 2023 08:44
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
update cmeps build to implement check4nans feature using module stored in cdeps repo
@DeniseWorthen
Copy link
Collaborator Author

I am running the logs now after the two dependent PRs have been merged.

@zach1221
Copy link
Collaborator

zach1221 commented Oct 6, 2023

I am running the logs now after the two dependent PRs have been merged.

Ok, great. We can start this PR once your tests are finished.

Edit: let's wait, and get 1925 done before 1907.

@DeniseWorthen
Copy link
Collaborator Author

I made a boo-boo running the logs and need to start over :-(

@zach1221
Copy link
Collaborator

zach1221 commented Oct 6, 2023

I made a boo-boo running the logs and need to start over :-(

Ah, yes. It happens to us all. All good.

@DeniseWorthen DeniseWorthen added No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Oct 7, 2023
@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Oct 8, 2023
@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@DeniseWorthen
Copy link
Collaborator Author

@zach1221 When you squash merge, can you make the commit message just this

remove mean prefix for fields imported to FV3atm from CICE or CMEPS
rename fv3atm export fields for snow and rain as inst

@zach1221
Copy link
Collaborator

@zach1221 When you squash merge, can you make the commit message just this

remove mean prefix for fields imported to FV3atm from CICE or CMEPS
rename fv3atm export fields for snow and rain as inst

Yes, I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify "mean" and "inst" coupled fields exchanged
6 participants