Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of FV3 diag table documentation #2277

Closed
wants to merge 90 commits into from
Closed

Creation of FV3 diag table documentation #2277

wants to merge 90 commits into from

Conversation

selbigmtnwx23
Copy link
Collaborator

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * stochastic_physics -

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

  • Closes #
  • None

Sub component Pull Requests:

  • AQM:
  • CDEPS:
  • CICE:
  • CMEPS:
  • CMakeModules:
  • FV3:
    • ccpp-physics:
    • atmos_cubed_sphere:
  • GOCART:
  • HYCOM:
  • MOM6:
  • NOAHMP:
  • WW3:
  • stochastic_physics:
  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • New input data.
  • Updated input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@selbigmtnwx23
added diag_table for FV3
8a0ae13 
Variable list for FV3 component of WM
@selbigmtnwx23
Update InputsOutputs.rst
cc7bb07 
added Fv3 diag table
@selbigmtnwx23
Update InputsOutputs.rst
7fccb6d
@selbigmtnwx23
Create fv3_diag_table.rst
19adab1
@selbigmtnwx23
Add files via upload
98ba8a7
@selbigmtnwx23
Delete doc/UsersGuide/source/diag_table FV3.rst
ba0e355
@selbigmtnwx23
Update InputsOutputs.rst
ee384fa
@selbigmtnwx23
Update fv3_diag_table.rst
9295d7c
@selbigmtnwx23
Update fv3_diag_table.rst
90f4943
@selbigmtnwx23
Update fv3_diag_table.rst
7c12a68
@selbigmtnwx23
Update fv3_diag_table.rst
6465fed
@selbigmtnwx23
Update InputsOutputs.rst
33eee5f
@selbigmtnwx23
Update fv3_diag_table.rst
2ad0de4
@selbigmtnwx23
Update fv3_diag_table.rst
f2ec776
@selbigmtnwx23
Update InputsOutputs.rst
2a0e49d
@selbigmtnwx23
Create mom6_diag_table.rst
c709a28
@selbigmtnwx23
Update InputsOutputs.rst
a3a573a
@selbigmtnwx23
Update InputsOutputs.rst
ac88d16
@selbigmtnwx23
Update fv3diagtable.csv
652700d 
spell check
@selbigmtnwx23
Create mom6diagtable.csv
b91f19b
@selbigmtnwx23
Delete doc/UsersGuide/source/tables/mom6diagtable.csv
bd5a0f9
@selbigmtnwx23
mom6 diag table
b38186e
@selbigmtnwx23
Delete doc/UsersGuide/source/tables/mom6diagtable.csv
129d468
@selbigmtnwx23
Add files via upload
d0bec6b
@selbigmtnwx23
Update mom6diagtable.csv
5b60c93
@selbigmtnwx23
Update mom6_diag_table.rst
7185457
@selbigmtnwx23
Update mom6_diag_table.rst
a8921bd
@selbigmtnwx23
Update mom6_diag_table.rst
18bf56f
@selbigmtnwx23
Update mom6_diag_table.rst
e1c3ffc
@selbigmtnwx23
Update fv3_diag_table.rst
d27d198
selbigmtnwx23 and others added 2 commits May 28, 2024 12:16
@selbigmtnwx23 @gspetro-NOAA
Update doc/UsersGuide/source/tables/fv3diagtable.csv
04b6aa2 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@selbigmtnwx23 @gspetro-NOAA
Update doc/UsersGuide/source/tables/fv3diagtable.csv
e83f151 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@DeniseWorthen DeniseWorthen added the documentation Improvements or additions to documentation label May 31, 2024
gspetro-NOAA and others added 7 commits July 2, 2024 13:16
@gspetro-NOAA
minor formatting
d99f102
@gspetro-NOAA
fix links
8a319a5
@selbigmtnwx23 @gspetro-NOAA
Update doc/UsersGuide/source/InputsOutputs.rst
61721ff 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@selbigmtnwx23 @gspetro-NOAA
Update doc/UsersGuide/source/InputsOutputs.rst
ec98649 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@selbigmtnwx23 @gspetro-NOAA
Update doc/UsersGuide/source/tables/fv3_diag_table.rst
c353e7d 
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@gspetro-NOAA
Merge branch 'diag-tables' of https://github.com/selbigmtnwx23/ufs-we…
d051a55 
…ather-model into feature/diag_tables
@selbigmtnwx23
Merge pull request #1 from gspetro-NOAA/feature/diag_tables
408c7a8 
Linkcheck fixes
gspetro-NOAA
gspetro-NOAA previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian has made all requested changes. PR looks good on my end.

@selbigmtnwx23 selbigmtnwx23 marked this pull request as ready for review July 9, 2024 17:53
@gspetro-NOAA gspetro-NOAA changed the title Creation of MOM6 and FV3 diag tables Creation of FV3 diag table documentation Jul 9, 2024
gspetro-NOAA
gspetro-NOAA previously approved these changes Jul 9, 2024
View reviewed changes
@jkbk2004 jkbk2004 mentioned this pull request Aug 8, 2024
Merged
14 tasks
zach1221 pushed a commit that referenced this pull request Aug 12, 2024
@jkbk2004
Addition of python script to add yaml-based test option + Creation of…
a1143cc 
… FV3 diag table documentation #2277 + SKEB fix with d_con = zero #2374 (#2278)

* UFSWM - python scripts for yaml and rocoto-xml conversion, experiment setup, and test log output  
* Add python superlint option
* Documentation update: doc/UsersGuide/source/tables/fv3_diag_table.rst
    * FV3 - 
    * atmos_cubed_sphere - bugfix: allocates heat_source when skeb is True and d_con is zero
@jkbk2004
Copy link
Collaborator

merged with #2278

@jkbk2004 jkbk2004 closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspetro-NOAA gspetro-NOAA gspetro-NOAA left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@selbigmtnwx23 @jkbk2004 @gspetro-NOAA @DeniseWorthen