Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running both Intel and GNU regression tests using ecflow on the same machine (node) #273

Closed

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Description

Provide list of files to be compared in two debug regression test (#23).
Do not load fv3 modules in the rt.sh. The fv3 module will be loaded in the compile and run scripts (#235).
Rocoto must pass PATHTR environment variable via workflow xml file.
When rocoto is used increase build time on wcoss_dell to 60min (one of the coupled compilation times out)

Issue(s) addressed

Issue #23
Issue #235

Testing

New baselines required for fv3_ccpp_control_debug and fv3_ccpp_stretched_nest_debug.

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as draft November 12, 2020 15:02
@DusanJovic-NOAA DusanJovic-NOAA added the Baseline Updates Current baselines will be updated. label Nov 12, 2020
@climbfuji
Copy link
Collaborator

Thanks for fixing those debug tests! Just curious, does this still compile without the -e or -c flags?

@DusanJovic-NOAA
Copy link
Collaborator Author

Thanks for fixing those debug tests! Just curious, does this still compile without the -e or -c flags?

Yes, it does.

MinsukJi-NOAA added a commit to MinsukJi-NOAA/ufs-weather-model that referenced this pull request Nov 18, 2020
@MinsukJi-NOAA MinsukJi-NOAA mentioned this pull request Nov 19, 2020
@DusanJovic-NOAA DusanJovic-NOAA deleted the rt_debug_files branch December 3, 2020 14:40
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
## Description of changes:

* Update grid parameters of GSD_HRRR3km grid of type JPgrid (including its task layout and blocksize) and enable running with it in NCO mode.  The new grid parameters are set to values specified by Christina Holt of GSL.  
* Update the write-component grid parameters associated with this grid such that the former is within the latter.
* Add two WE2E tests in NCO mode to run on this grid -- one using FV3GFS for ICs and LBCs (nco_GSD_HRRR3km_FV3GFS_FV3GFS) and another using HRRRX for ICs and RAPX for LBCs (nco_GSD_HRRR3km_HRRRX_RAPX).  First test works but the second doesn't due to a yet-unknown problem in chgres_cube, but the test may work with an older executable that GSL will use.
* Bug fix: Add the FV3GFS_2017_gfdlmp_regional physics suite to the if-statements in exregional_make_ics.sh and exregional_make_lbcs.sh that set numsoil_out.
* Improvement: Add "else" clauses to the if-statements in exregional_make_ics.sh and exregional_make_lbcs.sh that check for the physics suite to set various parameters.  These "else" clauses print out an error message whenever the specified physics suite is not covered by the if-statement.

## Tests conducted:

### On hera:
Ran all the WE2E tests including the two new ones (nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX).  All tests except regional_010 pass (regional_010 test was already broken in the original develop branch).

### On jet:
Ran the two new WE2E tests nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX as well as regional_002 and regional_003.  All passed, although some tasks (make_lbcs and run_fcst) for the nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX tests took more than 1 try to succeed.  Also tested versions of nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX in which the external files are staged.  Again, both succeeded but some tasks take more than 1 try to succeed.
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
## DESCRIPTION OF CHANGES:
Changes to three WE2E tests needed to run successfully on hera that were left out of PR #273.

## TESTS CONDUCTED:
Same as PR#273.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants