Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression tests that are not looking for specific output files can fail silently #23

Closed
climbfuji opened this issue Dec 30, 2019 · 7 comments
Closed

Regression tests that are not looking for specific output files can fail silently #23

climbfuji opened this issue Dec 30, 2019 · 7 comments
Assignees
@DusanJovic-NOAA

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Dec 30, 2019 •
edited
Loading

Some of the DEBUG regression tests do not check for the presence of output files generated by the model, the idea being that the code should just run and complete without an error. However, even if the code crashes rt.sh still thinks that the model ran ok (see issue #24 for an example).
@climbfuji climbfuji mentioned this issue Dec 30, 2019
Closed
@climbfuji climbfuji mentioned this issue Jan 7, 2020
Merged
@climbfuji
Copy link
Collaborator Author

climbfuji commented Jan 7, 2020 •
edited
Loading

This issue is avoided for the ufs_public_release branches only in #25 by explicitly checking for output files from the DEBUG tests.

@junwang-noaa junwang-noaa mentioned this issue Feb 2, 2020
Merged
@junwang-noaa
Copy link
Collaborator

Dom,

Do you still want to work on this issue, or if we can close it?

@climbfuji
Copy link
Collaborator Author

I think this needs to be fixed for the develop branch - all debug tests should look for specific output files.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Feb 19, 2020 via email

climbfuji pushed a commit to climbfuji/ufs-weather-model that referenced this issue Jun 2, 2020
@DomHeinzeller
Merge pull request ufs-community#23 from climbfuji/gsd_develop_blocke…
7aa630e 
…d_data_structures

gsd/develop: handle blocked data structures in init and finalize routines, remove pset logic, metadata cleanup
@climbfuji
Copy link
Collaborator Author

@junwang-noaa do you know if this has been fixed, i.e. are all DEBUG tests looking for output files nowadays? I know that all the DEBUG tests I put in do.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 21, 2020 via email

DeniseWorthen added a commit that referenced this issue Nov 9, 2020
@DeniseWorthen
update cmeps, fix debug compile, rename nems.configure files for coup…
4e8ef6a 
…led model (#254)

* Implements a bugfix for the mapping of ifrac for both nems_orig and nems_frac in CMEPS: issue (#17)[NOAA-EMC/CMEPS#17]
* Adds field-packing for performance improvements in CMEPS: issue (#23)[NOAA-EMC/CMEPS#23]
* Uses module file fv3_debug when DEBUG=Y is specified and fv3_debug is available
* Shortens the nems.configure file name used with the coupled model
@DusanJovic-NOAA DusanJovic-NOAA mentioned this issue Nov 12, 2020
Closed
@climbfuji
Copy link
Collaborator Author

Closed via 248b609

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@JeffBeck-NOAA
Update manage_externals for Python 3+ big fix, add support for Python…
fe82465 
… 3.7 and 3.8 (#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DusanJovic-NOAA DusanJovic-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@climbfuji @junwang-noaa @DusanJovic-NOAA