Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system and regression testing on Acorn #809

Closed
wants to merge 13 commits into from

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Sep 16, 2021

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Update the build system to support WCOSS2 TDS (Acorn) and update regression test scripts. No changes in baselines is expected. No new input data required.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first? No.

@climbfuji
Copy link
Collaborator

I will test this as soon as I get access to acorn (@arunchawla-NOAA is working on it, thanks a lot).

@climbfuji
Copy link
Collaborator

@DusanJovic-NOAA do you want to include the submodule pointer update for CMakeModules (NOAA-EMC/CMakeModules#57) in this PR?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA do you want to include the submodule pointer update for CMakeModules (NOAA-EMC/CMakeModules#57) in this PR?

@junwang-noaa already merged this branch in #819 and started regression testing.

@climbfuji
Copy link
Collaborator

@DusanJovic-NOAA do you want to include the submodule pointer update for CMakeModules (NOAA-EMC/CMakeModules#57) in this PR?

@junwang-noaa already merged this branch in #819 and started regression testing.

Ah ok, no problem. I can add it to my next PR then.

@climbfuji
Copy link
Collaborator

@DusanJovic-NOAA do you want to include the submodule pointer update for CMakeModules (NOAA-EMC/CMakeModules#57) in this PR?

@junwang-noaa already merged this branch in #819 and started regression testing.

Ah ok, no problem. I can add it to my next PR then.

Done.

@junwang-noaa
Copy link
Collaborator

Committed through PR#819, close PR.

@DusanJovic-NOAA DusanJovic-NOAA deleted the acorn_rt branch September 30, 2021 13:42
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Remove RRFS_v1alpha suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates for WCOSS2 TDS (Acorn)
3 participants