-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ode solver with sundials third party library. #1109
Conversation
@@ -121,7 +121,7 @@ TEST(MathLibCVodeTest, ZeoliteAdsorption) | |||
|
|||
ode_solver->setFunction(f_zeolite, nullptr); | |||
|
|||
ode_solver->setIC(0.0, {pV, C}); | |||
ode_solver->setIC(0.0, {{pV, C}}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for my understanding: That's due to some c++11 std::array constructor implementation "bug", right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be. I do remember something about std::array. On the other hand std::array is just struct, so it could be related to struct's initialization.
235dfc9
to
77c2de3
Compare
return successful ? 0 : 1; | ||
}; | ||
|
||
// TODO: check not run twice! move this call somewhere else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the comment is not needed anymore. ✅
@endJunction, I checked your branch yesterday evening at commit 77c2de3. I only have three simple suggestions:
|
a5c6080
to
392bcd3
Compare
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1484/ |
Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/1349/ |
Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/1368/ |
Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/1458/ |
Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/1370/ |
Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1348/ |
@endJunction Feel free to |
if (CVODE_FOUND) | ||
target_link_libraries(MathLib INTERFACE | ||
GeoLib | ||
logog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs GeoLib and logog ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Added doc link on main page.
And also in the tests prevent abort if no ODE solver can be created.
OpenGeoSys development has been moved to GitLab. |
This is an adaptation and cleanup of Christophs ode solver interface.
Todo (unordered list):