Added flexible nonlinear solver convergence criteria #1342
Conversation
chleh
force-pushed
the
conv-crit
branch
3 times, most recently
from
036923f
to
c54d2a5
Compare
|
I'd like to finish the documentation during code review once everybody agrees about the general structures introduced in this PR. So please at least have a brief look at the three pieces highlighted above. |
|
Jenkins, test this please. |
| namespace MeshLib | ||
| { | ||
| class Mesh; | ||
| } // Mesh |
There was a problem hiding this comment.
If commenting, then 'namespace MeshLib', please. 👍
|
Technically OK, didn't look into design too much, tough. Maybe a 10 minutes overview on Monday would be beneficial. |
| return createConvergenceCriterionPerComponentDeltaX(config); | ||
| } | ||
|
|
||
| OGS_FATAL("There is no convergence criterion of type `%s'.", type.c_str()); |
There was a problem hiding this comment.
``%s'->'%s'`? i mean using a single quotation for both. If it's your intention, it's ok.
There was a problem hiding this comment.
I usually intend it this way.
|
and where is a convergence criterion class checking a relative error? |
|
|
|
sorry i meant residual check |
|
you can support residual check later but keep in mind tha one can not trust Newton result without checking residuals. |
|
⏩ from my side. |
|
|
||
| if ((!abstols) && (!reltols)) | ||
| OGS_FATAL( | ||
| "At least one of absolute or relative tolerance has to be " |
There was a problem hiding this comment.
but the constructor of ConvergenceCriterionPerComponentDeltaX requires both abstols and retools are provided...
|
I just added a separate function for relative tolerance checks, which also works if b in |
|
👍 |
1 similar comment
|
👍 |
|
OpenGeoSys development has been moved to GitLab. |
Follow-up of #1315 and of #1349.Closes #1339.
Core things:
TODO
For later: