Kelvin vector symmetric tensor conversion #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the test to Tests/MathLib and extract MathLib::tensorToKelvin for completness.
endJunction
force-pushed
the
KelvinVectorSymmetricTensorConversion
branch
from
6cfaaf6
to
3ce6178
Compare
chleh
approved these changes
Feb 13, 2018
| template <typename Derived> | ||
| Eigen::Matrix<double, Eigen::MatrixBase<Derived>::RowsAtCompileTime, 1> | ||
| symmetricTensorToKelvinVector(Eigen::MatrixBase<Derived> const& v) | ||
| { |
There was a problem hiding this comment.
Maybe add static_assert(Eigen::MatrixBase<Derived>::ColsAtCompileTime == 1, "ERR");
MathLib/KelvinVector.h
Outdated
| { | ||
| Eigen::Matrix<double, Eigen::MatrixBase<Derived>::RowsAtCompileTime, 1> | ||
| result; | ||
| if (v.size() == 4) |
There was a problem hiding this comment.
This if-clause also covers dynamically allocated matrices, but don't you have to specify their size manually before filling them with the << operator?
wenqing
approved these changes
Feb 13, 2018
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2060 with fixes to the symmetric tensor to/from Kelvin vector conversion, now tested.
This came up during Integration point data to VTK's field data output PR.