Move bc meshes #2141
Merged
Move bc meshes #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
force-pushed
the
MoveBCMeshes
branch
4 times, most recently
from
6206851
to
3475743
Compare
TomFischer
reviewed
Jun 12, 2018
|
|
||
| int const selected_component_id = 1; | ||
|
|
||
| // Subset the original cmap. | ||
| MeshComponentMap cmap_subset = | ||
| cmap->getSubset({selected_component_id}, selected_component); | ||
| MeshComponentMap cmap_subset = cmap->getSubset( |
There was a problem hiding this comment.
MeshComponentMap const cmap_subset = ...? ✔️
TomFischer
approved these changes
Jun 12, 2018
endJunction
force-pushed
the
MoveBCMeshes
branch
2 times, most recently
from
8c72274
to
ea71b6b
Compare
TomFischer
reviewed
Jun 12, 2018
NumLib/DOF/LocalToGlobalIndexMap.cpp
Outdated
| auto mesh_component_map = _mesh_component_map.getSubset( | ||
| global_component_ids, _mesh_subsets, new_mesh_subset); | ||
| #ifndef NDEBUG | ||
| std::cout << "bc mesh component map:\n" << mesh_component_map << "\n"; |
There was a problem hiding this comment.
Output should use logog. ✔️
endJunction
force-pushed
the
MoveBCMeshes
branch
from
ea71b6b
to
2c72750
Compare
chleh
approved these changes
Jun 13, 2018
MeshLib/Mesh.h
Outdated
| @@ -285,4 +286,7 @@ PropertyVector<T>* getOrCreateMeshProperty(Mesh& mesh, | |||
| return result; | |||
| } | |||
|
|
|||
| std::unique_ptr<MeshLib::Mesh> createMeshFromElementSelection( | |||
| DBUG("Found %d elements in the mesh", elements.size()); | ||
|
|
||
| // Store bulk element ids for each of the new elements. | ||
| std::vector<std::size_t> bulk_element_ids; |
MeshLib/Mesh.cpp
Outdated
| nodes_map[n] = new MeshLib::Node(*n); | ||
| } | ||
|
|
||
| e->setNode(i, nodes_map[n]); |
There was a problem hiding this comment.
Minor: it could be reused here if it's not end().
MeshLib/Mesh.cpp
Outdated
| std::vector<std::size_t> bulk_node_ids; | ||
| std::transform(begin(nodes_map), end(nodes_map), | ||
| std::back_inserter(bulk_node_ids), | ||
| [&](auto const& pair) { return pair.first->getID(); }); |
MeshLib/Mesh.cpp
Outdated
| std::vector<MeshLib::Node*> element_nodes; | ||
| std::transform(begin(nodes_map), end(nodes_map), | ||
| std::back_inserter(element_nodes), | ||
| [&](auto const& pair) { return pair.second; }); |
| BaseLib::ConfigTree const& config, | ||
| const NumLib::LocalToGlobalIndexMap& dof_table, std::size_t const mesh_id, | ||
| std::size_t const node_id, const int variable_id, const int component_id, | ||
| BaseLib::ConfigTree const& config, MeshLib::Mesh& st_mesh, |
| @@ -15,9 +15,9 @@ | |||
| namespace ProcessLib | |||
| { | |||
| std::unique_ptr<NodalSourceTerm> createNodalSourceTerm( | |||
| BaseLib::ConfigTree const& config, | |||
| BaseLib::ConfigTree const& config, MeshLib::Mesh& st_mesh, | |||
| std::size_t const node_id, | ||
| const int variable_id, const int component_id, | ||
| std::size_t const bulk_mesh_id, | ||
| MeshLib::Mesh& st_mesh, |
There was a problem hiding this comment.
const ref mesh? and so on :-)
| { | ||
| std::vector<MeshLib::Mesh*> additional_meshes; | ||
|
|
||
| // TODO (naumov) add config for search length algorithms. |
There was a problem hiding this comment.
I'm curious how long it takes until the first users will complain, because their BCs are too "shitty" 😄
| /// For each named geometry in the give geo_objects (defined on the given \c | ||
| /// mesh) constructs a mesh corresponding to the geometry with mappings to the | ||
| /// bulk mesh elements and nodes. | ||
| std::vector<MeshLib::Mesh*> constructAdditionalMeshesFromGeoObjects( |
There was a problem hiding this comment.
Also maybe vector of unique_ptrs.
|
@chleh All valid points, thanks! I'll fix them today. |
endJunction
force-pushed
the
MoveBCMeshes
branch
from
46cd101
to
50602dc
Compare
A mesh is constructed from (cloned) elements preserving original element and node ids in two mesh properties.
All named geometries are converted to meshes (with same names). These meshes will be used by the boundary conditions and source term constructors.
Find a boundary mesh in the list of meshes instead of using GeoObjects and pass it to the boundary condition creation.
If the boundary mesh is larger then the definition region of the bulk component, then a nop is returned. This usually indicates wrong geometry or something horrible.
The mid point is not available on all meshes.
warning: explicit link request to '_elements' could not be resolved doxygen 1.8.14
endJunction
force-pushed
the
MoveBCMeshes
branch
from
50602dc
to
a88f3f9
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeding the "Move BC meshes; preparations #2140" PR.
Three major parts: