First version of constraint boundary conditions #2145

TomFischer · 2018-06-19T07:45:07Z

For discussion:

Output information via DBUG or INFO?
Open question: How to specify which getFlux function (for instance heat, mass or Darcy flux) should be used for the constraint calculation?

wenqing · 2018-06-19T10:09:26Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+    ProcessLib::createLocalAssemblers<
+        ConstraintDirichletBoundaryConditionLocalAssembler>(
+        _bulk_mesh.getDimension(), _bc_mesh.getElements(),
+        *_dof_table_boundary, 1, _local_assemblers, false, _integration_order,


How about to introduce two constants as:

const int component = 1; const bool lower = false;

to replace the numbers, 1. false, in the argument list?

Replacing the number makes the code more readable. Are you sure the suggested names are correct? What do think about the following replacements:

const int shape_function_order = 1; const bool is_axisymmetric = false;

?

Sorry I've checked a wrong argument list. The names of shape_function_order and is_axisymmetric are correct.

wenqing · 2018-06-19T13:55:47Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+        unsigned const number_nodes = boundary_element->getNumberOfNodes();
+        for (unsigned i = 0; i < number_nodes; ++i)
+        {
+            unsigned const id = boundary_element->getNode(i)->getID();


getID() returns std::size_t.

Changed to auto.

wenqing · 2018-06-19T14:05:54Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.h

+class ConstraintDirichletBoundaryCondition final : public BoundaryCondition
+{
+public:
+    /// @param parameter used for setting the values for the boundary condition


It is better to capitalize the first letter of argument comment.

Capitalized.

endJunction · 2018-06-20T10:25:29Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+    }
+
+    // make the pairs (node id, value) unique
+    std::sort(tmp_bc_values.begin(), tmp_bc_values.end(),


The comment is about making vector unique, but here it's only sorted... ???

endJunction · 2018-06-20T10:28:01Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryConditionLocalAssembler.h

+    /// @param integration_order The order of the integration.
+    ConstraintDirichletBoundaryConditionLocalAssembler(
+        MeshLib::Element const& surface_element,
+        std::size_t /*const local_matrix_size*/,


Commenting 'const' changes function's signature...

endJunction · 2018-06-20T10:29:48Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryConditionLocalAssembler.h

+
+    IntegrationMethod const _integration_method;
+    std::size_t _bulk_element_id;
+    unsigned _bulk_face_id;


these _bulk_*_id are not const?

endJunction · 2018-06-20T10:34:09Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+        });
+
+    const int shape_function_order = 1;
+    const bool is_axisymmetric = false;


isn't this a property of the bc_mesh?

endJunction · 2018-06-20T10:42:17Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+        // check if the boundary element is active
+        if (_lower)
+        {
+            if (_flux_values[boundary_element->getID()] < _constraint_threshold)


A comparator before the for-loop would be better:

auto is_flux = [&](std::size_t const element_id) { return _lower ? _flux_values[element_id] < _constraint_threshold : _flux_values[element_id] > _constraint_threshold; } for ( ... boundary elements ...) { if (is_flux(boundary_element->getID()) { continue; } ... }

endJunction · 2018-06-20T10:45:17Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+    //! \ogs_file_param{prj__process_variables__process_variable__boundary_conditions__boundary_condition__ConstraintDirichletBoundaryCondition__constraining_process_variable}
+        config.getConfigParameter<std::string>("constraining_process_variable");
+
+    const int process_id = 0; // assume monolithic implementation


Maybe this can be checked if the constraining_process is monolithic?

endJunction · 2018-06-25T12:01:19Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryConditionLocalAssembler.h

+private:
+    MeshLib::Element const& _surface_element;
+
+    std::vector<double> _detJ_times_integralMeasure;


integration point weight could also be added (multiplied) in the same scalar...

endJunction · 2018-06-25T12:02:08Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryConditionLocalAssembler.h

+        // for correct results it is necessary to multiply the normal with -1
+        surface_element_normal *= -1;
+
+        std::size_t const n_integration_points =


I'd recommend to use 'auto' here... The return type might change, and is currently an 'unsigned int'.

endJunction · 2018-06-25T12:05:09Z

ProcessLib/HT/Tests.cmake

+    ConstViscosityThermalConvection_pcs_0_ts_3_t_0.001010.vtu ConstViscosityThermalConvection_pcs_0_ts_3_t_0.001010.vtu p p 1e-15 1e-14
+    ConstViscosityThermalConvection_pcs_0_ts_4_t_0.101010.vtu ConstViscosityThermalConvection_pcs_0_ts_4_t_0.101010.vtu p p 1e-15 1e-14
+    ConstViscosityThermalConvection_pcs_0_ts_5_t_1.101010.vtu ConstViscosityThermalConvection_pcs_0_ts_5_t_1.101010.vtu p p 1e-15 1e-14
+    ConstViscosityThermalConvection_pcs_0_ts_6_t_10.000000.vtu ConstViscosityThermalConvection_pcs_0_ts_6_t_10.000000.vtu p p 1e-15 1e-14


Could be reduced to two lines using GLOBs. See https://github.com/ufz/ogs/blob/master/ProcessLib/RichardsComponentTransport/Tests.cmake#L10-L11

endJunction · 2018-06-25T12:09:59Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.cpp

+
+    // make the pairs (node id, value) unique
+    // first: sort the (node id, value) pairs according to the node id
+    std::sort(tmp_bc_values.begin(), tmp_bc_values.end(),


Sorry, but I still don't see where the tmp_bc_values are "made unique". There is a copy, but not a std::unique followed by erase....

I changed the comment.

endJunction · 2018-06-25T12:10:41Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryCondition.h

+                                      GlobalVector const&)>
+            getFlux);
+
+    ~ConstraintDirichletBoundaryCondition() = default;


Can be dropped, isn't it?

endJunction · 2018-06-25T12:12:08Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryConditionLocalAssembler.h

+        // At the moment (2018-04-26) the surface normal is not oriented
+        // according to the right hand rule
+        // for correct results it is necessary to multiply the normal with -1
+        surface_element_normal *= -1;


Computing a normalized surface normal for element/face could be a free function in MeshLib.

endJunction · 2018-06-25T12:14:09Z

ProcessLib/BoundaryCondition/ConstraintDirichletBoundaryConditionLocalAssembler.h

+                Eigen::Map<Eigen::RowVectorXd const>(bulk_flux.data(),
+                                                     bulk_flux.size())
+                    .dot(Eigen::Map<Eigen::RowVectorXd const>(
+                        surface_element_normal.getCoords(), 3)));


Since the surface element normal does not change, it could be stored in the integration point data...

The normal doesn't change for all integration points, am I right? For this reason, I made the normal an attribute of the object and did not move it to the integration point data.

The current implementation is returning a constant normal vector for each element. This is not correct...

First version of constraint boundary conditions

ogsbot · 2020-06-19T12:53:10Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

TomFischer force-pushed the ConstraintBCs branch from 4fbed0f to 6210aeb Compare June 19, 2018 11:19

wenqing reviewed Jun 19, 2018

View reviewed changes

endJunction reviewed Jun 20, 2018

View reviewed changes

TomFischer force-pushed the ConstraintBCs branch 3 times, most recently from d71e80d to 7db4f7b Compare June 22, 2018 09:40

endJunction reviewed Jun 25, 2018

View reviewed changes

endJunction mentioned this pull request Jun 25, 2018

Move BC meshes post refactoring #2153

Merged

1 task

TomFischer added 11 commits June 26, 2018 12:46

[PL] Docu update.

601843b

[PL] Impl. of ConstraintDirichletBoundaryCondition.

f73b0f9

[PL] ConstraintDirichletBC: Add 'links' to docu.

8af8353

[PL] Add todo for open question.

a5f5c4e

[PL] Implementation of createConstraintDirichletBC.

0631370

[PL] Forward the process to the constraint BCs.

8406944

[T/Data] Add test for the constraint Dirichlet bc.

d8be02c

[PL] ConstraintDirichletBC: Docu for the website.

9fb62d2

[PL/ConstraintDirichletBC] Add IntegrationPointData.

00999f9

[PL/ConstraintDirichletBC] Mv calc. of normal to constr.

9d8a9cd

[PL/ConstraintDirichletBC] Mv bulk_element_point to int. pt. data.

909e251

TomFischer added 4 commits June 26, 2018 12:46

[PL/ConstraintDirichletBC] bulk_mesh isn't needed anymore.

2f8cd6c

[PL/ConstraintDirichletBC] _bulk_face_id isn't needed anymore.

c155d27

[MeL] Impl. of calculateNormalizedSurfaceNormal().

c3d48a3

[PL/ConstraintDirichletBC] Use calculateNormalizedSurfaceNormal().

ac1a2b0

TomFischer force-pushed the ConstraintBCs branch from 7db4f7b to ac1a2b0 Compare June 26, 2018 10:47

endJunction merged commit e54815c into ufz:master Jun 27, 2018

TomFischer deleted the ConstraintBCs branch June 28, 2018 04:06

bilke pushed a commit to bilke/ogs that referenced this pull request Jul 2, 2018

Merge pull request ufz#2145 from TomFischer/ConstraintBCs

861cfa3

First version of constraint boundary conditions

endJunction mentioned this pull request Jul 11, 2018

Allow multiple meshes in project #2156

Merged

chleh mentioned this pull request Aug 13, 2018

Python BCs #2170

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First version of constraint boundary conditions #2145

First version of constraint boundary conditions #2145

TomFischer commented Jun 19, 2018

wenqing Jun 19, 2018

TomFischer Jun 20, 2018

wenqing Jun 20, 2018

wenqing Jun 19, 2018

TomFischer Jun 20, 2018

wenqing Jun 19, 2018

TomFischer Jun 20, 2018

endJunction Jun 20, 2018

endJunction Jun 20, 2018

endJunction Jun 20, 2018

endJunction Jun 20, 2018

endJunction Jun 20, 2018

endJunction Jun 20, 2018

endJunction Jun 25, 2018

endJunction Jun 25, 2018

endJunction Jun 25, 2018

endJunction Jun 25, 2018

TomFischer Jun 26, 2018

endJunction Jun 25, 2018

endJunction Jun 25, 2018

endJunction Jun 25, 2018

TomFischer Jun 26, 2018

endJunction Jun 27, 2018

ogsbot commented Jun 19, 2020

First version of constraint boundary conditions #2145

First version of constraint boundary conditions #2145

Conversation

TomFischer commented Jun 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogsbot commented Jun 19, 2020