Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BC meshes post refactoring #2153

Merged
merged 12 commits into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@endJunction
Copy link
Member

endJunction commented Jun 25, 2018

  • Removal of special Neumann BC for LIE: This simplifies the rest of the BoundaryCondition implementation.
  • Simplification of boundary condition/source terms builders.
  • Extract reading of the meshes in ProjectData and store as unique_ptr's.
  • Improve several other points related to the meshes and their usage in BCs.

This is preparation for the PR allowing multiple meshes to be given in the project file and used as BCs/STs and in general define multiple discrete domains of definition.

To be merged after the "constrained BCs" #2145.

TODO:

  • Update hash for the latest master including the LIE/Neumann BCs.

@endJunction endJunction force-pushed the endJunction:MoveBCMeshesPostRefactoring branch from 4f47b37 to 3f4338f Jun 25, 2018

@TomFischer
Copy link
Member

TomFischer left a comment

Looks good! After resolving conflicts:

@endJunction endJunction force-pushed the endJunction:MoveBCMeshesPostRefactoring branch from 3f4338f to e8e4e32 Jun 28, 2018

endJunction added some commits Jun 12, 2018

[PL] LIE; Remove special Neumann BC for disp.jump.
The boundary condition is not used in any test so far
and the physical interpretation of that BC is difficult
at least.

The removal greatly simplifies few things.

The Dirichlet BC is still available.
[A] PrjData: Move creation of meshes in own fct.
This also allows to remove the _geoObjects member from the ProjectData.
[MGTL] Pass axial symmetry to constructed meshes.
The bulk mesh property must be set on the newly created
meshes. The bulk mesh is not available upon the mesh construction
and it is simpler to set the property afterwards, than
to pass it through two function calls.
[NL] DOF; Fix variable offsets for derived table.
The variable component offsets are absolute and the derived
DOF table must have all the bulk DOF table global component
offset for each variable.

@endJunction endJunction force-pushed the endJunction:MoveBCMeshesPostRefactoring branch from e8e4e32 to 2031e44 Jun 28, 2018

@endJunction endJunction merged commit 2171706 into ufz:master Jun 28, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@endJunction endJunction deleted the endJunction:MoveBCMeshesPostRefactoring branch Jun 28, 2018

bilke added a commit to bilke/ogs that referenced this pull request Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.