Move BC meshes post refactoring #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
force-pushed
the
MoveBCMeshesPostRefactoring
branch
from
4f47b37
to
3f4338f
Compare
TomFischer
approved these changes
Jun 28, 2018
endJunction
force-pushed
the
MoveBCMeshesPostRefactoring
branch
from
3f4338f
to
e8e4e32
Compare
The boundary condition is not used in any test so far and the physical interpretation of that BC is difficult at least. The removal greatly simplifies few things. The Dirichlet BC is still available.
This also allows to remove the _geoObjects member from the ProjectData.
The bulk mesh property must be set on the newly created meshes. The bulk mesh is not available upon the mesh construction and it is simpler to set the property afterwards, than to pass it through two function calls.
The variable component offsets are absolute and the derived DOF table must have all the bulk DOF table global component offset for each variable.
endJunction
force-pushed
the
MoveBCMeshesPostRefactoring
branch
from
e8e4e32
to
2031e44
Compare
bilke
pushed a commit
to bilke/ogs
that referenced
this pull request
Jul 2, 2018
Move BC meshes post refactoring
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for the PR allowing multiple meshes to be given in the project file and used as BCs/STs and in general define multiple discrete domains of definition.
To be merged after the "constrained BCs" #2145.
TODO: