Added an element test as a LIE cohesive zone benchmark #2157

renchao-lu · 2018-07-03T13:04:10Z

This pull request is motivated to enrich secondary variables in the LIE/SmallDeformation as in the LIE/HydroMechanics, and add an element test for LIE cohesive zone model. The extended secondary variables consist of a fracture opening vector (w_n and w_s) and a fracture stress vector (f_stress_normal and f_stress_shear). With these output variables, it becomes more straightforward to make a comparison against the analytical solution in the element test.

renchao-lu · 2018-07-13T12:20:41Z

Based upon the request, postTimestepConcreteProcess is replaced with computeSecondaryVariableConcrete in LIE/SmallDeformation.

endJunction · 2018-07-13T15:06:13Z

Few more small things:

remove the executable flag from test files, e.g. Tests/Data/LIE/Mechanics/cohesive_zone_load_path.gml (chmod a-x Tests/Data/LIE/Mechanics/cohesive_zone_load_path.gml)
remove the pvd file from tests

endJunction · 2018-07-13T15:08:13Z

ProcessLib/LIE/SmallDeformation/Tests.cmake

@@ -89,10 +89,14 @@ AddTest(
    TESTER vtkdiff
    REQUIREMENTS NOT OGS_USE_MPI
    DIFF_DATA
-    GLOB cohesive_zone_load_path_pcs_0_ts_*.vtu displacement displacement 1e-16 0


Put back the comparison of displacement, displacement_jump1, and sigma_*.

Use GLOB pattern, instead of writing out each time step.

The tolerances for the stress_n are rather loose; how come?

f_stress_n_analytical

The GLOB pattern sounds like making the file comparison with an identical file name in the different folders. I am not sure.

Yes, it does compare the files from the source folder (expected output) to the build folder (ctest output) and the files are named identically. Simply do as for displacement etc.

The expected output contains the analytical solution 'f_stress_n_analytical' which is not included in the ctest output though... Can we make a comparison against the analytical solution at some selected rather than all the instants?

endJunction · 2018-07-13T15:09:39Z

ProcessLib/LIE/SmallDeformation/SmallDeformationProcess.cpp

+    auto mesh_prop_w_n = MeshLib::getOrCreateMeshProperty<double>(
+        const_cast<MeshLib::Mesh&>(mesh), "w_n",
+        MeshLib::MeshItemType::Cell, 1);
+    mesh_prop_w_n->resize(mesh.getNumberOfElements());


The resize is not necessary. It's already done in the MeshLib::getOrCreateMeshProperty...

endJunction · 2018-07-13T15:12:15Z

ProcessLib/LIE/SmallDeformation/SmallDeformationProcessData.h

+    MeshLib::PropertyVector<double>* _mesh_prop_w_n = nullptr;
+    MeshLib::PropertyVector<double>* _mesh_prop_w_s = nullptr;
+    MeshLib::PropertyVector<double>* _mesh_prop_fracture_stress_shear = nullptr;
+    MeshLib::PropertyVector<double>* _mesh_prop_fracture_stress_normal = nullptr;


I'd try to use either _n and _s or _normal and _shear, but not to mix the both.

renchao-lu · 2018-07-14T10:26:04Z

Checklist

Remove the executable flag from test files, e.g. Tests/Data/LIE/Mechanics/cohesive_zone_load_path.gml (chmod a-x Tests/Data/LIE/Mechanics/cohesive_zone_load_path.gml) [Done, appreciate it]
Remove the pvd file from tests [Done]
Put back the comparison of displacement, displacement_jump1, and sigma_*. [Done]
Use GLOB pattern, instead of writing out each time step. [Done]
The tolerances for the stress_n are rather loose; how come? [Fixed]
Truncation of the variable 'w_n' causes the loss of accuracy in the previous calculation of analytical solution. Now it is fixed. The relative tolerance is reverted back to 5e-6.
f_stress_n_analytical [Done]
Clang-format [Learned, Done]
Removed the particular commit for clang-formatting. Instead, it is done before making a commit.
Add a python script for describing how the analytical solution is computed (in Tests/Data/LIE/M) [to do]

endJunction

Looks good!

I was wondering how you computed the analytical solution; if there is a python script or something please include it here too (in Tests/Data/LIE/M). A description in "Selected Benchmarks" would be nice too.

@fparisio @nagelt You might want to have a look on the results.

wenqing

Looks good.

wenqing · 2018-07-20T14:01:09Z

ProcessLib/LIE/SmallDeformation/LocalAssembler/SmallDeformationLocalAssemblerInterface.h

+    {
+        if (!_dofIndex_to_localIndex.empty())
+        {
+            auto const local_dof_size = local_x_.size();


You can directly use local_x_.size() in the following for loop.

Replaced accordingly.

wenqing · 2018-07-20T14:01:33Z

ProcessLib/LIE/SmallDeformation/LocalAssembler/SmallDeformationLocalAssemblerInterface.h

+            auto const local_dof_size = local_x_.size();
+
+            _local_u.setZero();
+            for (unsigned i = 0; i < local_dof_size; i++)


Change unsigned to std::size_t.

Changed accordingly.

chleh · 2018-07-24T07:29:46Z

ProcessLib/LIE/SmallDeformation/SmallDeformationProcess.h

@@ -45,6 +44,9 @@ class SmallDeformationProcess final : public Process
    bool isLinear() const override;
    //! @}

+    void computeSecondaryVariableConcrete(double const t,


Sorry for the late comment. AFAIK computeSecondaryVariableConcrete() is called after every single iteration.
In contrast postTimestepConcreteProcess() is called only after each timestep, so probably much less often. You seem to use the secondary variables only for output. Wouldn't postTimestepConcreteProcess() therefore suffice?
The only corner case that I am aware of is the output of iteration results. Or am I missing something?
For later developments, of course a preOutput() method would be a good option.

I thought it would be the other way around, but it looks like the compute secondary vars is called just after postTimestep UncoupledTimeLoop.cpp.

I agree with the need for preOutput(). --> another PR.

I'd suggest to keep this implementation for now.

Yep, implementation can be kept. Then I was wrong. Maybe then in the future the two methods can be combined.

…crete.

endJunction · 2018-08-05T11:45:58Z

@renchao-lu I've seen you want to add a python-script to the tests/data, that's great! Just add it when you are ready as another PR.

ogsbot · 2020-06-19T12:53:26Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

renchao-lu force-pushed the LIECohesiveZone_Benchmark branch 5 times, most recently from e0c3025 to 65db158 Compare July 6, 2018 11:22

renchao-lu force-pushed the LIECohesiveZone_Benchmark branch from 65db158 to b572c2d Compare July 13, 2018 12:11

endJunction reviewed Jul 13, 2018

View reviewed changes

renchao-lu force-pushed the LIECohesiveZone_Benchmark branch 4 times, most recently from 1f436db to 175a9af Compare July 18, 2018 18:32

endJunction force-pushed the LIECohesiveZone_Benchmark branch from 175a9af to f645f3e Compare July 19, 2018 11:11

renchao-lu force-pushed the LIECohesiveZone_Benchmark branch from f645f3e to efe2297 Compare July 19, 2018 14:58

endJunction approved these changes Jul 19, 2018

View reviewed changes

wenqing approved these changes Jul 20, 2018

View reviewed changes

renchao-lu force-pushed the LIECohesiveZone_Benchmark branch from efe2297 to 520e039 Compare July 23, 2018 22:27

chleh reviewed Jul 24, 2018

View reviewed changes

renchao-lu added 3 commits August 5, 2018 12:04

Replaced postTimestepConcreteProcess with computeSecondaryVariableCon…

e148079

…crete.

Added more secondary variables.

8461129

Added an element test as a benchmark of cohesive zone model.

5e5263a

endJunction force-pushed the LIECohesiveZone_Benchmark branch from 520e039 to 5e5263a Compare August 5, 2018 10:05

endJunction merged commit 622b10c into ufz:master Aug 5, 2018

renchao-lu deleted the LIECohesiveZone_Benchmark branch December 20, 2018 10:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added an element test as a LIE cohesive zone benchmark #2157

Added an element test as a LIE cohesive zone benchmark #2157

renchao-lu commented Jul 3, 2018

renchao-lu commented Jul 13, 2018 •

edited

Loading

endJunction commented Jul 13, 2018

endJunction Jul 13, 2018 •

edited

Loading

renchao-lu Jul 14, 2018 •

edited

Loading

endJunction Jul 14, 2018

renchao-lu Jul 14, 2018 •

edited

Loading

endJunction Jul 13, 2018

endJunction Jul 13, 2018

renchao-lu commented Jul 14, 2018 •

edited

Loading

endJunction left a comment

wenqing left a comment

wenqing Jul 20, 2018

renchao-lu Jul 23, 2018

wenqing Jul 20, 2018

renchao-lu Jul 23, 2018

chleh Jul 24, 2018

endJunction Jul 24, 2018

chleh Jul 24, 2018

endJunction commented Aug 5, 2018

ogsbot commented Jun 19, 2020

Added an element test as a LIE cohesive zone benchmark #2157

Added an element test as a LIE cohesive zone benchmark #2157

Conversation

renchao-lu commented Jul 3, 2018

renchao-lu commented Jul 13, 2018 • edited Loading

endJunction commented Jul 13, 2018

endJunction Jul 13, 2018 • edited Loading

Choose a reason for hiding this comment

renchao-lu Jul 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

renchao-lu Jul 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

renchao-lu commented Jul 14, 2018 • edited Loading

endJunction left a comment

Choose a reason for hiding this comment

wenqing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction commented Aug 5, 2018

ogsbot commented Jun 19, 2020

renchao-lu commented Jul 13, 2018 •

edited

Loading

endJunction Jul 13, 2018 •

edited

Loading

renchao-lu Jul 14, 2018 •

edited

Loading

renchao-lu Jul 14, 2018 •

edited

Loading

renchao-lu commented Jul 14, 2018 •

edited

Loading