[Jenkins] New warnings publisher syntax

[bilke]

See https://jenkins.io/blog/2018/09/11/speaker-blog-warnings-plugin/

Provides a better overview over warnings. I suggest to

• Fix warnings
• Exclude remaining warnings
• Set warning thresholds (to 0 or a specified number) to mark build as unstable

[endJunction]

All of the doxygen warnings are ignorable. There two types max_graph_nodes too small, and a warning in functional.h about recursion.

[bilke]

It seems that filtering by warning message is not possible yet: https://github.com/jenkinsci/warnings-plugin/blob/master/doc/Documentation.md#filtering-issues

Before we filtered the Doxygen warnings. (.*DOT_GRAPH_MAX_NODES. and *potential recursive class relation.*)

[endJunction]

One of the MSVC warnings ('void (__cdecl *volatile )(void)': top-level volatile in cast is ignored) could be potentially fixed by

diff --git a/Applications/CLI/ogs_embedded_python.cpp b/Applications/CLI/ogs_embedded_python.cpp
index 2da7a23d1..39b6e3e28 100644
--- a/Applications/CLI/ogs_embedded_python.cpp
+++ b/Applications/CLI/ogs_embedded_python.cpp
@@ -28,7 +28,7 @@ PYBIND11_EMBEDDED_MODULE(OpenGeoSys, m)
 template <typename T>
 void mark_used(T p)
 {
-    volatile T vp = (volatile T)p;
+    volatile T vp = p;
     vp = vp;
 }

but since I'm not able to use shared libraries with python, I cannot test its correctness.

[endJunction]

Another deprecated warning is the QVTKWidget, which is to be replaced with QVTKOpenGLWidget.
Starting naïve commit produces a segv on DataExplorer's start because the get render window returns null in visualizationWidget ctor

vtkWidget->GetRenderWindow()->GetInteractor()->SetInteractorStyle(_interactorStyle);
``

[chleh]

One of the MSVC warnings ('void (__cdecl *volatile )(void)': top-level volatile in cast is ignored) could be potentially fixed by

diff --git a/Applications/CLI/ogs_embedded_python.cpp b/Applications/CLI/ogs_embedded_python.cpp
index 2da7a23d1..39b6e3e28 100644
--- a/Applications/CLI/ogs_embedded_python.cpp
+++ b/Applications/CLI/ogs_embedded_python.cpp
@@ -28,7 +28,7 @@ PYBIND11_EMBEDDED_MODULE(OpenGeoSys, m)
 template <typename T>
 void mark_used(T p)
 {
-    volatile T vp = (volatile T)p;
+    volatile T vp = p;
     vp = vp;
 }

but since I'm not able to use shared libraries with python, I cannot test its correctness.

@endJunction, that code is intended to capture static libs + Python. Is there a problem for you using shared libs and Python?

[endJunction]

@chleh Yes. See also #2184 (comment) . Let's continue the discussion there. I'll be in the office after lunch.

[bilke]

@endJunction Thanks for your fixes!

[ogsbot]

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.