Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conan per default when available #2207

Merged
merged 3 commits into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@bilke
Copy link
Member

bilke commented Sep 13, 2018

Use Conan as default when its executable is found. Developer having Conan installed typically also want to use it for third-party library handling. This avoids strange things happening when switching Conan to ON from the CMake GUI.

If you don't want to use Conan:

  • Do not have conan in your PATH, OR
  • Set OGS_USE_CONAN=OFF

@HaibingShao With this merged you can again use the CMake GUI for the initial CMake run if you like...

bilke added some commits Sep 13, 2018

[CMake] Use Conan as default when executable is found.
Developer having Conan installed typically also want to use it
for third-party library handling. This avoids strange things
happening when switching Conan to ON from the CMake GUI.

@bilke bilke added the please review label Sep 13, 2018

@endJunction
Copy link
Member

endJunction left a comment

Looks cleaner to me this way.

@bilke bilke removed the please review label Sep 14, 2018

@bilke bilke merged commit 0aec010 into ufz:master Sep 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@bilke bilke deleted the bilke:conan-default branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.