Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conan per default when available #2207

Merged
merged 3 commits into from
Sep 14, 2018
Merged

Use Conan per default when available #2207

merged 3 commits into from
Sep 14, 2018

Conversation

bilke
Copy link
Member

@bilke bilke commented Sep 13, 2018

Use Conan as default when its executable is found. Developer having Conan installed typically also want to use it for third-party library handling. This avoids strange things happening when switching Conan to ON from the CMake GUI.

If you don't want to use Conan:

  • Do not have conan in your PATH, OR
  • Set OGS_USE_CONAN=OFF

@HaibingShao With this merged you can again use the CMake GUI for the initial CMake run if you like...

Developer having Conan installed typically also want to use it
for third-party library handling. This avoids strange things
happening when switching Conan to ON from the CMake GUI.
Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner to me this way.

@bilke bilke merged commit 0aec010 into ufz:master Sep 14, 2018
@bilke bilke deleted the conan-default branch September 14, 2018 06:50
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants