LIE intersect (continued). #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop the unnecessary 'inline', because of a template function.
The usage in the code is simpler due to value semantics. Initialization is more safe.
Also add a constructor for simple members of the BranchProperty. Fix node_id type.
Also add a ctor for RAII.
No underscore for public members; Drop type prefix from the name.
clang-tidy '*readability-braces-around-statements'
|
Docker-Conan error. |
wenqing
reviewed
Dec 11, 2018
| _process_data._vec_junction_property.emplace_back(junction); | ||
| auto const& material_ids = vec_junction_nodeID_matIDs[i].second; | ||
| assert(material_ids.size() == 2); | ||
| std::array<int, 2> fracture_ids{ |
There was a problem hiding this comment.
warning: suggest braces around initialization of subobject.
The use of double braces should fix the warning.
There was a problem hiding this comment.
Thanks, added in master.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2235 continued, especially addressing issues pointed out by @wenqing.