Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIE intersect (continued). #2293

Merged
merged 13 commits into from
Dec 11, 2018
Merged

LIE intersect (continued). #2293

merged 13 commits into from
Dec 11, 2018

Commits on Dec 10, 2018

  1. [PL] LIE; Rename functions camelCase.

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    6523656 View commit details
    Browse the repository at this point in the history

  2. [PL] LIE/post; Rename function to reflect purpose.

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    5207e0f View commit details
    Browse the repository at this point in the history

  3. [BL] Use Container::value_type in contains(). 

    Also drop the unnecessary 'inline', because of a template function.
    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    7db97fa View commit details
    Browse the repository at this point in the history

  4. [BL] Add findIndex(container, element) algorithm.

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    b94fe63 View commit details
    Browse the repository at this point in the history

  5. [BL] Generalize findFirstNotEqualElement(c, e).

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    1b9ecb9 View commit details
    Browse the repository at this point in the history

  6. [PL] LIE/post; Use BaseLib::findIndex().

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    aa36349 View commit details
    Browse the repository at this point in the history

  7. [PL] LIE/SD; Remove unused variable.

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3ecc5fe View commit details
    Browse the repository at this point in the history

  8. [PL] LIE; Use FractureProperty as value, not ptr. 

    The usage in the code is simpler due to value semantics.
Initialization is more safe.
    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    6b96bc5 View commit details
    Browse the repository at this point in the history

  9. [PL] LIE; Avoid ptr usage with BranchProperty. 

    Also add a constructor for simple members of the BranchProperty.
Fix node_id type.
    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    ff49ff8 View commit details
    Browse the repository at this point in the history

  10. [PL] Avoid ptr usage with JunctionProperty. 

    Also add a ctor for RAII.
    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    13d6e47 View commit details
    Browse the repository at this point in the history

  11. [PL] LIE; consistently name fracture/junction prop 

    No underscore for public members;
Drop type prefix from the name.
    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    d74f8de View commit details
    Browse the repository at this point in the history

  12. [PL] LIE; Use int for dimension.

    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    1f26cc0 View commit details
    Browse the repository at this point in the history

  13. [PL] LIE; Add braces around statements; 

    clang-tidy '*readability-braces-around-statements'
    @endJunction
    endJunction committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    f8c6dd1 View commit details
    Browse the repository at this point in the history