Output primary variables on arbitrary meshes. #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
reviewed
Dec 17, 2018
ProcessLib/Output/Output.cpp
Outdated
| @@ -145,9 +158,9 @@ void Output::doOutputAlways(Process const& process, | |||
| time_output.start(); | |||
|
|
|||
| // Need to add variables of process to vtu even no output takes place. | |||
| processOutputData(t, x, process.getMesh(), process.getDOFTable(process_id), | |||
| processOutputData(t, x, *_meshes[0], process.getDOFTable(process_id), | |||
wenqing
approved these changes
Dec 17, 2018
ProcessLib/Output/Output.cpp
Outdated
|
|
||
| DBUG("output to %s", mesh_output_file_path.c_str()); | ||
|
|
||
| //ProcessData* process_data = findProcessData(process, process_id); |
There was a problem hiding this comment.
Do you still need these two lines?
There was a problem hiding this comment.
Add TODO for pvd and then a note for merging the bulk and arbitrary mesh output
endJunction
reviewed
Dec 18, 2018
ProcessLib/Output/Output.cpp
Outdated
|
|
||
| processOutputData(t, x, mesh, *mesh_dof_table, | ||
| process.getProcessVariables(process_id), | ||
| process.getSecondaryVariables(), false, |
There was a problem hiding this comment.
false -> false /* no secondary vars output*/
endJunction
reviewed
Dec 18, 2018
ProcessLib/Output/Output.cpp
Outdated
| // For the staggered scheme for the coupling, only the last process, | ||
| // which gives the latest solution within a coupling loop, is allowed to | ||
| // make output. | ||
| if (!(process_id == |
endJunction
approved these changes
Dec 18, 2018
ProcessLib/Output/Output.cpp
Outdated
|
|
||
| DBUG("output to %s", mesh_output_file_path.c_str()); | ||
|
|
||
| //ProcessData* process_data = findProcessData(process, process_id); |
There was a problem hiding this comment.
Add TODO for pvd and then a note for merging the bulk and arbitrary mesh output
The functionality of the ProcessVariable isn't needed here.
TomFischer
force-pushed
the
ArbitraryOutput
branch
from
b5f16bf
to
d4a959a
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.