Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output primary variables on arbitrary meshes. #2299

Merged
merged 13 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@TomFischer
Copy link
Member

TomFischer commented Dec 17, 2018

As titled.

@@ -145,9 +158,9 @@ void Output::doOutputAlways(Process const& process,
time_output.start();

// Need to add variables of process to vtu even no output takes place.
processOutputData(t, x, process.getMesh(), process.getDOFTable(process_id),
processOutputData(t, x, *_meshes[0], process.getDOFTable(process_id),

This comment has been minimized.

@endJunction

endJunction Dec 17, 2018

Member

discussion needed.

@wenqing
Copy link
Member

wenqing left a comment

Looks good except that is commented by Dima.


DBUG("output to %s", mesh_output_file_path.c_str());

//ProcessData* process_data = findProcessData(process, process_id);

This comment has been minimized.

@wenqing

wenqing Dec 17, 2018

Member

Do you still need these two lines?

This comment has been minimized.

@endJunction

endJunction Dec 18, 2018

Member

Add TODO for pvd and then a note for merging the bulk and arbitrary mesh output


processOutputData(t, x, mesh, *mesh_dof_table,
process.getProcessVariables(process_id),
process.getSecondaryVariables(), false,

This comment has been minimized.

@endJunction

endJunction Dec 18, 2018

Member

false -> false /* no secondary vars output*/

// For the staggered scheme for the coupling, only the last process,
// which gives the latest solution within a coupling loop, is allowed to
// make output.
if (!(process_id ==

This comment has been minimized.

@endJunction

endJunction Dec 18, 2018

Member

predicate


DBUG("output to %s", mesh_output_file_path.c_str());

//ProcessData* process_data = findProcessData(process, process_id);

This comment has been minimized.

@endJunction

endJunction Dec 18, 2018

Member

Add TODO for pvd and then a note for merging the bulk and arbitrary mesh output

@TomFischer TomFischer force-pushed the TomFischer:ArbitraryOutput branch from b5f16bf to d4a959a Dec 18, 2018

@TomFischer TomFischer merged commit d0b5a61 into ufz:master Dec 19, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details

@TomFischer TomFischer deleted the TomFischer:ArbitraryOutput branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.