Local coordinate system #2370

endJunction · 2019-02-19T15:10:25Z

See the project file for the new possibilities. <local_coordinate_system> and a tag in permeability parameter "k" for usage.
The designated parameters will be transformed according to the given local coordinate system.
An additional if-condition is introduced in all parameters, but it has less than 1% impact on the runtime.
Review commit-wise is possible.

TODO:

Agree on the input file tags. (decided to keep basis vectors)
Documentation for the basis vector (which might change with the above tags todo).
Showcase for anisotropic tensor (3D would be preferable, because 2D is already tested in RM)

codecov · 2019-02-20T12:06:36Z

Codecov Report

Merging #2370 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
- Coverage    32.9%   32.73%   -0.18%     
==========================================
  Files         530      530              
  Lines       19816    19850      +34     
  Branches     9258     9325      +67     
==========================================
- Hits         6521     6498      -23     
- Misses       9975     9999      +24     
- Partials     3320     3353      +33

Impacted Files	Coverage Δ
Applications/ApplicationsLib/ProjectData.h	`0% <ø> (ø)`	⬆️
Applications/ApplicationsLib/ProjectData.cpp	`0% <0%> (ø)`	⬆️
MathLib/Vector3.cpp	`33.33% <0%> (-33.34%)`	⬇️
MeshLib/CoordinateSystem.cpp	`42.85% <0%> (-14.29%)`	⬇️
GeoLib/SimplePolygonTree.cpp	`61.9% <0%> (-4.77%)`	⬇️
GeoLib/AnalyticalGeometry-impl.h	`72.95% <0%> (-4.1%)`	⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp	`68.18% <0%> (-3.04%)`	⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp	`76.74% <0%> (-2.33%)`	⬇️
GeoLib/MinimalBoundingSphere.cpp	`41.17% <0%> (-1.97%)`	⬇️
MeshLib/MeshSurfaceExtraction.cpp	`30.81% <0%> (-1.26%)`	⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec75045...baf3fe9. Read the comment docs.

JobstM · 2019-02-21T20:57:32Z

I just took a brief look on the project file - for me it's ok. One question: How to define multiple local coordinate systems?
Best

endJunction · 2019-02-22T00:46:56Z

@JobstM Do you mean for different material groups? Or, indeed, multiple, space-dependent coordinate systems?

JobstM · 2019-02-22T08:33:10Z

I mean the possibility to define several coordinate systems, which could be used eg in different areas (material groups) or different material models (eg permeability, elasticity, heat conductivity). Example: A model with 3 material groups, in material group 1, the permeability tensor is inclined by 20 deg, in material group 2 and 3 by 30 deg.

wenqing · 2019-02-22T09:32:49Z

ProcessLib/Parameter/CoordinateSystem.cpp

+        _base[1]->getNumberOfComponents() != 2)
+    {
+        OGS_FATAL("The parameters for the 2D basis must have two components.");
+    }


In case there are wrong input by mistakes, it is also good to check the values of the bases, such as e_i \dot e_j := (i==j) ? 1, 0.

Checking the determinant of the transformation matrix to be close to 1. In debug build only, though.

wenqing · 2019-02-22T09:33:33Z

ProcessLib/Parameter/CoordinateSystem.cpp

+        OGS_FATAL(
+            "The parameters for the 3D basis must have three components.");
+    }
+}


Here the same, to check the values of the base vectors.

wenqing · 2019-02-22T09:48:49Z

Tests/Data/RichardsMechanics/flow_fully_saturated_coordinate_system.prj

+            </variables>
+        </output>
+    </time_loop>
+    <local_coordinate_system>


There may be not only one local system in some cases. It might be good to use a nested elements as

<local_coordinate_system> <local_coordinate_system> <name> x1 </name> <basis_vector_0>e0</basis_vector_0> <basis_vector_1>e1</basis_vector_1> </local_coordinate_system> </local_coordinate_system>

@JobstM Material group dependent coordinate systems are not a problem with a single <local_coordinate_system> tag.This is because the parameters for the base vectors can be group based. An (untested) example:

<local_coordinate_system> <basis_vector_0>e0</basis_vector_0> <basis_vector_1>e1</basis_vector_1> </local_coordinate_system> <parameters> <parameter> <name>e0</name> <type>Group</type> <group_id_property>MaterialIDs</group_id_property> <index_values> <index>0</index> <values>1 0 0</value>  </index_values> <index_values> <index>1</index> <value>0.707 0.707 0</value>  </index_values> </parameter> <parameter> <name>e1</name> <type>Group</type> <group_id_property>MaterialIDs</group_id_property> <index_values> <index>0</index> <values>0 1 0</value>  </index_values> <index_values> <index>1</index> <value>-0.707 0.707 0</value>  </index_values> </parameter> </parameters>

More local_coordinate_system-tags are then only necesary if different parameters for the same material group have distinct principle directions? Or is there a way to represent this in the structure, too?

I see. The current implementation can handle multi-local systems

@ThieJan Like this (figure from the Internet)

What Jan says is correct, the multiple <local_coordinate_system> tags would only be necessary if, for example, temperature diffusion lives in a different coordinate system than the hydraulic permeability.

Suggest to wait until such a project comes up; the implementation is simple, just a name and instead of boolean <use_local_coordinate_system> a specific coordinate system would be referenced.

Another possible input could be:

<local_coordinate_system> <basis_matrix>basis</basis_matrix> </local_coordinate_system> <parameters> <parameter> <name>basis</name> <type>Group</type> <group_id_property>MaterialIDs</group_id_property> <index_values> <index>0</index> <values>1 0 0 0 1 0 0 0 1</value>  </index_values> <index_values> <index>1</index> <values>0.707 0.707 0 -0.707 0.707 0 0 0 1</values>  </index_values> </parameter> </parameters>

endJunction · 2019-03-08T08:46:29Z

@TomFischer or @wenqing I've added a 3D test for anisotropy but had to extend the GWF. Could you please review the last two commits?

TomFischer · 2019-03-08T11:25:57Z

ProcessLib/Utils/ProcessUtils.cpp

+
+    if (it == parameters.end())
+    {
+        return nullptr;


Is this a usual case? Maybe add also some debug output to detect if there is an error?

The nullptr is checked later by the caller, which issues a warning or whatever.

TomFischer

Looks good. ⏩

wenqing

The 3D test looks good.
⏩

wenqing · 2019-03-08T12:51:44Z

ProcessLib/GroundwaterFlow/GroundwaterFlowFEM.h

@@ -28,6 +28,34 @@ namespace GroundwaterFlow
 {
 const unsigned NUM_NODAL_DOF = 1;

+template <int GlobalDim>
+Eigen::Matrix<double, GlobalDim, GlobalDim> hydraulicConductivity(


Nice. It can be a common function for similar tensor parameters.

wenqing · 2019-03-08T14:28:44Z

ProcessLib/GroundwaterFlow/Tests.cmake

@@ -757,3 +757,5 @@ AddTest(
    DIFF_DATA
    square_1x1_quad_1e5.vtu square_1e5_volumetricsourceterm_pcs_0_ts_1_t_1.000000.vtu analytical_solution pressure 0.75e-4 1e-16
 )
+


if (NOT OGS_USE_MPI) OgsTest(PROJECTFILE "Elliptic/cube_1x1x1_GroundWaterFlow/cube_1e4_anisotropic.prj") endif()

The truncated version is not exactly comparable with the coordinate transformation version and results deviate by 10^-7. Better to use accurate representation of the tensor for the comparisons.

Only for debug mode, because the transformation can not be efficiently precomputed in the general case.

Calls corresponding to the dimension rotation function from the coordinate system.

And set the coordinate systems in those parameters having this tag set true.

endJunction · 2019-03-09T18:23:39Z

I've removed the split of findParameterOptional and findParameterByName, because there is a circular dependecy (on header files level) btw. the ProcessLib and MaterialLib. This is handled in a different PR.

ogsbot · 2020-06-19T12:58:12Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

endJunction force-pushed the LocalCoordinateSystem branch 3 times, most recently from ad47ae8 to 2eba549 Compare February 20, 2019 12:06

endJunction force-pushed the LocalCoordinateSystem branch from 2eba549 to 9bb8ef3 Compare February 21, 2019 09:14

bilke force-pushed the LocalCoordinateSystem branch from c742830 to afdd43f Compare February 22, 2019 09:36

wenqing reviewed Feb 22, 2019

View reviewed changes

endJunction force-pushed the LocalCoordinateSystem branch 2 times, most recently from 5d56d4f to 682872c Compare February 22, 2019 14:42

wenqing approved these changes Feb 22, 2019

View reviewed changes

endJunction force-pushed the LocalCoordinateSystem branch 3 times, most recently from e0103a1 to ffe4466 Compare March 8, 2019 08:45

endJunction force-pushed the LocalCoordinateSystem branch from ffe4466 to 1661688 Compare March 8, 2019 09:47

TomFischer reviewed Mar 8, 2019

View reviewed changes

TomFischer approved these changes Mar 8, 2019

View reviewed changes

wenqing reviewed Mar 8, 2019

View reviewed changes

endJunction force-pushed the LocalCoordinateSystem branch from 1661688 to 12443b4 Compare March 8, 2019 22:23

endJunction added 7 commits March 9, 2019 13:56

[T] RM; Use accurate anisotropic tensor.

ce84de9

The truncated version is not exactly comparable with the coordinate transformation version and results deviate by 10^-7. Better to use accurate representation of the tensor for the comparisons.

[T] RM; New tests files for coordinate system.

1e425d4

[PL] Coordinate system

5168b66

[PL] CoordinateSystem. Add debug build det=1 check

45bf587

Only for debug mode, because the transformation can not be efficiently precomputed in the general case.

[PL] Parameter; Add optional coordinate system.

0ee2aa9

[PL] Parameter; Add rotateWithCoordinateSystem.

1dea631

Calls corresponding to the dimension rotation function from the coordinate system.

[PL] Add coordinate transformation for parameters.

7c73655

endJunction and others added 6 commits March 9, 2019 13:56

[AppL] Parse local coordinate system in project.

4912d30

[AppL] Move up parameter initialization.

0259b6b

[AppL] Parse <use_local_coordinate_system> tag.

fc75e84

And set the coordinate systems in those parameters having this tag set true.

[doc] Local coordinate system and parameter tag.

c578d6c

[PL] GWF; Anisotropic hydraulic conductivity.

6bf8029

[T] GWF; Anisotropic test with local coord sys.

baf3fe9

endJunction force-pushed the LocalCoordinateSystem branch from 12443b4 to baf3fe9 Compare March 9, 2019 12:57

endJunction merged commit a2f8e2a into ufz:master Mar 9, 2019

endJunction deleted the LocalCoordinateSystem branch March 9, 2019 18:24

endJunction mentioned this pull request Mar 9, 2019

Extract Parameter and co in own library. #2413

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local coordinate system #2370

Local coordinate system #2370

endJunction commented Feb 19, 2019 •

edited

Loading

codecov bot commented Feb 20, 2019 •

edited

Loading

JobstM commented Feb 21, 2019

endJunction commented Feb 22, 2019

JobstM commented Feb 22, 2019

wenqing Feb 22, 2019

endJunction Feb 22, 2019

wenqing Feb 22, 2019

wenqing Feb 22, 2019

wenqing Feb 22, 2019

endJunction Feb 22, 2019

ThieJan Feb 22, 2019

wenqing Feb 22, 2019

endJunction Feb 22, 2019 •

edited

Loading

endJunction Feb 22, 2019

endJunction commented Mar 8, 2019

TomFischer Mar 8, 2019

endJunction Mar 8, 2019

TomFischer left a comment

wenqing left a comment

wenqing Mar 8, 2019

wenqing Mar 8, 2019 •

edited

Loading

endJunction commented Mar 9, 2019

ogsbot commented Jun 19, 2020

Local coordinate system #2370

Local coordinate system #2370

Conversation

endJunction commented Feb 19, 2019 • edited Loading

codecov bot commented Feb 20, 2019 • edited Loading

Codecov Report

JobstM commented Feb 21, 2019

endJunction commented Feb 22, 2019

JobstM commented Feb 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction Feb 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction commented Mar 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomFischer left a comment

Choose a reason for hiding this comment

wenqing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wenqing Mar 8, 2019 • edited Loading

Choose a reason for hiding this comment

endJunction commented Mar 9, 2019

ogsbot commented Jun 19, 2020

endJunction commented Feb 19, 2019 •

edited

Loading

codecov bot commented Feb 20, 2019 •

edited

Loading

endJunction Feb 22, 2019 •

edited

Loading

wenqing Mar 8, 2019 •

edited

Loading