Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ExtractSurface tool #2387

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Conversation

TomFischer
Copy link
Member

Add the subsurface MaterialIDs to the extracted surface. This information can be further be used for setting the boundary conditions.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2387 into master will decrease coverage by 0.1%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
- Coverage   32.73%   32.63%   -0.11%     
==========================================
  Files         529      529              
  Lines       19896    19904       +8     
  Branches     9304     9354      +50     
==========================================
- Hits         6513     6495      -18     
+ Misses      10065    10050      -15     
- Partials     3318     3359      +41
Impacted Files Coverage Δ
MeshLib/MeshSurfaceExtraction.cpp 30.81% <33.33%> (-0.98%) ⬇️
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 71.31% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
GeoLib/Polyline.cpp 34.34% <0%> (-1.22%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1732741...54f61d1. Read the comment docs.

Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe we should think about transferring of all of the bulk mesh data arrays to the boundary meshes.

@endJunction endJunction merged commit 290f69a into ufz:master Mar 4, 2019
@TomFischer TomFischer deleted the ExtendExtractSurface branch March 5, 2019 07:28
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants