Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ExtractSurface tool #2387

Merged
merged 3 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@TomFischer
Copy link
Member

TomFischer commented Feb 26, 2019

Add the subsurface MaterialIDs to the extracted surface. This information can be further be used for setting the boundary conditions.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2387 into master will decrease coverage by 0.1%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
- Coverage   32.73%   32.63%   -0.11%     
==========================================
  Files         529      529              
  Lines       19896    19904       +8     
  Branches     9304     9354      +50     
==========================================
- Hits         6513     6495      -18     
+ Misses      10065    10050      -15     
- Partials     3318     3359      +41
Impacted Files Coverage Δ
MeshLib/MeshSurfaceExtraction.cpp 30.81% <33.33%> (-0.98%) ⬇️
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 71.31% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
GeoLib/Polyline.cpp 34.34% <0%> (-1.22%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1732741...54f61d1. Read the comment docs.

@endJunction
Copy link
Member

endJunction left a comment

Looks good.

Maybe we should think about transferring of all of the bulk mesh data arrays to the boundary meshes.

@TomFischer TomFischer force-pushed the TomFischer:ExtendExtractSurface branch from 0482d6a to 0b54846 Mar 4, 2019

@endJunction endJunction force-pushed the TomFischer:ExtendExtractSurface branch from 0b54846 to 7ba1b09 Mar 4, 2019

@endJunction endJunction force-pushed the TomFischer:ExtendExtractSurface branch from 7ba1b09 to 54f61d1 Mar 4, 2019

@endJunction endJunction merged commit 290f69a into ufz:master Mar 4, 2019

5 checks passed

codecov/patch 33.33% of diff hit (target 32.73%)
Details
codecov/project Absolute coverage decreased by -0.1% but relative coverage increased by +0.59% compared to 1732741
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
deploy/netlify Deploy preview ready!
Details
ufz.ogs #20190304.13 succeeded
Details

@TomFischer TomFischer deleted the TomFischer:ExtendExtractSurface branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.