Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPL] Change implementation of LinearProperty #2415

Merged
merged 4 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@TomFischer
Copy link
Member

TomFischer commented Mar 12, 2019

Changing from y_ref + m (p - p_ref) to y_ref (1 + m (p - p_ref)).

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #2415 into master will decrease coverage by 0.12%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
- Coverage   32.79%   32.66%   -0.13%     
==========================================
  Files         549      549              
  Lines       20286    20289       +3     
  Branches     9525     9571      +46     
==========================================
- Hits         6652     6627      -25     
+ Misses      10196    10187       -9     
- Partials     3438     3475      +37
Impacted Files Coverage Δ
MaterialLib/MPL/Properties/LinearProperty.cpp 66.66% <62.5%> (-13.34%) ⬇️
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
GeoLib/Polyline.cpp 35.31% <0%> (-1.88%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.81% <0%> (-1.26%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119c441...59ddbcd. Read the comment docs.

TomFischer added some commits Mar 12, 2019

[MPL] Change LinearProperty implementation.
reference_value * (1 + slope * (independent_variable - independent_variable_reference_condition))

@TomFischer TomFischer force-pushed the TomFischer:MPLLinearProperty branch from 733225f to e23c9f9 Mar 14, 2019

@endJunction endJunction merged commit 11eaad5 into ufz:master Mar 14, 2019

0 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
deploy/netlify Deploy preview processing.
Details

@TomFischer TomFischer deleted the TomFischer:MPLLinearProperty branch Mar 14, 2019

@endJunction endJunction referenced this pull request Apr 15, 2019

Closed

Gpml #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.