Time loop refactorings; Extract pre and post. #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
force-pushed
the
TimeLoopRefactorings
branch
2 times, most recently
from
9f1cb57
to
b0a585f
Compare
Unifies the monolithic and staggered cases.
Equal for both, the staggered and the monolithic cases.
Avoids "good" state by chance.
wenqing
approved these changes
Sep 19, 2019
ProcessLib/TimeLoop.cpp
Outdated
| NumLib::NonlinearSolverStatus nonlinear_solver_status; | ||
| preTimestepForAllProcesses(t, dt, _per_process_data, _process_solutions); | ||
|
|
||
| NumLib::NonlinearSolverStatus nonlinear_solver_status{false, -1}; |
There was a problem hiding this comment.
For a readable source code, suggest to define the two variables for the arguments of the ctor of NumLib::NonlinearSolverStatus. For example:
Suggested change
| NumLib::NonlinearSolverStatus nonlinear_solver_status{false, -1}; | |
| const bool error_norms_met = false; | |
| const int number_iterations = -1 | |
| NumLib::NonlinearSolverStatus nonlinear_solver_status{error_norms_met, number_iterations}; |
|
|
||
| NumLib::NonlinearSolverStatus nonlinear_solver_status{true, 0}; | ||
| NumLib::NonlinearSolverStatus nonlinear_solver_status{false, -1}; |
endJunction
force-pushed
the
TimeLoopRefactorings
branch
from
b0a585f
to
4493c7e
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
preTimestepandpostTimestepcalls into individual functions merging the monolithic and staggered implementations.No behavioural change for the staggered scheme.
For the monolithic scheme the
preTimestepcalls are now executed separately in the beginning.