Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont skip output of repeated fixed time step #3000

Merged

Conversation

endJunction
Copy link
Member

@endJunction endJunction commented Jun 12, 2020

Fixes missed output in case of repeated time step.

  • Feature description was added to the changelog

@endJunction endJunction marked this pull request as ready for review June 13, 2020 13:18
@endJunction endJunction requested a review from wenqing June 13, 2020 13:18
@wenqing
Copy link
Member

wenqing commented Jun 15, 2020

I am testing this.

Copy link
Member

@wenqing wenqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good. The tests including 1d-infiltration-RM give the correct output at the fixed times.

👍

@endJunction endJunction merged commit 600d6d9 into ufz:master Jun 16, 2020
@endJunction endJunction deleted the DontSkipOutputOfRepeatedFixedTimeStep branch June 16, 2020 10:04
@endJunction
Copy link
Member Author

The changes are good. The tests including 1d-infiltration-RM give the correct output at the fixed times.

For me it does not. Can you post your log file?

@wenqing
Copy link
Member

wenqing commented Jun 16, 2020

The changes are good. The tests including 1d-infiltration-RM give the correct output at the fixed times.

For me it does not. Can you post your log file?

I did not save the log file. It's weird it does not catch the time steps in my test now. I am going to check the source code. I am attaching a script for checking the output of 1d-infiltration-RM.
check_output.zip

@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants