You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One minor issue that we ran into when updating our fork was that the new error-wrapping behavior would cause tests to break. The tests would expect errors to be of a certain type, but since the returned error was wrapped, we'd have to change it to do string comparisons.
It's not too hard to change the wrapping to preserve the original error, and also to implement the causer interface from https://godoc.org/github.com/pkg/errors , which is the closest thing go has to a standard way of wrapping errors.
I implemented this in keybase#13 (with an example PR that uses it here: keybase/saltpack#67 ). Would there be any interest in merging it upstream?
The text was updated successfully, but these errors were encountered:
One minor issue that we ran into when updating our fork was that the new error-wrapping behavior would cause tests to break. The tests would expect errors to be of a certain type, but since the returned error was wrapped, we'd have to change it to do string comparisons.
It's not too hard to change the wrapping to preserve the original error, and also to implement the causer interface from https://godoc.org/github.com/pkg/errors , which is the closest thing go has to a standard way of wrapping errors.
I implemented this in keybase#13 (with an example PR that uses it here: keybase/saltpack#67 ). Would there be any interest in merging it upstream?
The text was updated successfully, but these errors were encountered: