Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Cards | show save / cancel buttons when user edits the From or To columns #33

Open
iKrushYou opened this issue Apr 24, 2024 · 6 comments

Comments

@iKrushYou
Copy link

if you update the date columns in From or To, the save / cancel buttons do not appear as you'd expect from editing another field

@uhppoted
Copy link
Owner

I've just checked this on Chrome, Firefox and Safari and it seems to work ok on all of them. Can you provide more information?

@iKrushYou
Copy link
Author

wow.. that is so strange. I am unable to reproduce this now. Sorry for the lack of information it was happening every time for me that it seemed straight forward

now, when I edit the date it shows the check box

@uhppoted
Copy link
Owner

Ok, at a guess the Javascript hadn't loaded for some reason - if/when it happens again maybe check the developer console.

@iKrushYou
Copy link
Author

I'll keep an eye out for that if it happens again
sorry for the false alarm :)

@iKrushYou iKrushYou reopened this Apr 27, 2024
@iKrushYou
Copy link
Author

I was able to reproduce in safari. it happens when you crate a user with an invalid start/end date. Turns out this is because of the current date placeholders that don't tell you that there actually isn't a value there. it makes it very difficult to know what the issue is with the red row / dates

Screen.Recording.2024-04-27.at.14.22.26.mp4

@uhppoted
Copy link
Owner

Ok, thanks - have added it to the tracking issue for card start/end dates. It is going to be a while before I get to it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants