Skip to content

Commit

Permalink
fix(decorateUIRouterViewConfigs): fix issue with key = but selfView d…
Browse files Browse the repository at this point in the history
…ef is ''

Closes #10
  • Loading branch information
Harman authored and christopherthielen committed May 5, 2018
1 parent 5504553 commit 3579894
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/decorateUIRouterViewConfigs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ hybridModule.config([

Object.keys(views).forEach(key => {
const view = views[key];
const selfView = selfViews[key];
const selfView = selfViews[key || '$default'];
const reactType = isReactComponent(view.component) && 'react';
view.$type = selfViews[key].$type || reactType || view.$type;

This comment has been minimized.

Copy link
@Anber

Anber May 16, 2018

Contributor

Looks like you forget to use selfView here. Should it be selfView.$type?

This comment has been minimized.

Copy link
@hrgui

hrgui May 19, 2018

Contributor

@christopherthielen It looks like this change doesn't have everything, see the following:

323faf1#diff-27859f2b9609526b65d934ba68e2dbd1R35

});
Expand Down

0 comments on commit 3579894

Please sign in to comment.