Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add badge number on TabItems #238

Closed
1 of 3 tasks
aman198 opened this issue Jan 28, 2018 · 12 comments
Closed
1 of 3 tasks

Can we add badge number on TabItems #238

aman198 opened this issue Jan 28, 2018 · 12 comments

Comments

@aman198
Copy link

aman198 commented Jan 28, 2018

New Issue Checklist

Issue Description

Other useful things

@msaps
Copy link
Member

msaps commented Feb 1, 2018

@aman198 not currently available, but will add it as in improvement! 👍

@msaps
Copy link
Member

msaps commented Feb 1, 2018

Could potentially be achieved with a custom TabmanBar currently, but would require a fair bit of work to achieve.

@aman198
Copy link
Author

aman198 commented Feb 2, 2018

Hi Friend,
First of all thanks for the prompt response ,
Can we make do it early we need to show that to our client.

@aman198
Copy link
Author

aman198 commented Feb 12, 2018

Hi,
I have added code for badge but can you tell me where I can find the code to check width of tabbar item as per screen so that I can add layer to that X position

@patniemeyer
Copy link

This is another case where simply marking fewer items as "internal" would allow people to work around limitations while you are developing. I know you want to guard the API while it's evolving, but for a project like this I think the trade-off of making the code more flexible vs. having some people potentially be disrupted by an update is a good one.

@msaps
Copy link
Member

msaps commented May 23, 2018

@patniemeyer one of the priorities for Tabman 2 😄

@rzulkoski
Copy link

rzulkoski commented Jun 4, 2018

@aman198 @msaps I have added support to Tabman 1 for displaying a badge on an item in pull request #294.

Updated docs can be found here.

Here's the default appearance using the badge text "New!":

Edit: I think I'm going to iterate on this a bit further. Closing the PR for now.

@vre142
Copy link

vre142 commented Dec 10, 2018

Hi, I add your great library with pod but I can't find badge for using can you help me about it?
THanks,
Vafa

@rzulkoski
Copy link

I don’t believe badge support has made it into the current release of Tabman yet. My understanding is that it should make it into Tabman 2.

@vre142
Copy link

vre142 commented Dec 10, 2018

I don’t believe badge support has made it into the current release of Tabman yet. My understanding is that it should make it into Tabman 2.

How can I add it by own in the library?

@msaps
Copy link
Member

msaps commented Dec 12, 2018

@rzulkoski @vre142 just released Tabman 2, which doesn't have this built in just yet as a native implementation. But things have been greatly improved in terms of customisation and extendability. This sort of thing could easily be achieved with a custom TMBarButton. (Check out the docs here for more).

I do still plan on adding this into Tabman natively, just didn't quite manage to get it in for 2.0. But at least it should be much easier to achieve for now.

@msaps
Copy link
Member

msaps commented Mar 8, 2019

Now available in 2.2.0 🎉

badge

@msaps msaps closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants