Misc. improvements #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 26, 2016 15:08
Two queries are equal if they have the same title; maybe not a good choice?
Note the package for the new framework is edu.gslis.scoring (as opposed to edu.gslis.docscoring for the existing scorers) to allow us to maintain the old scorers for backwards compatibility but keep the new scorers distinct.
|
@craig-willis Submitting this PR as part of our efforts to bring together our independent changes to ir-tools. If you have a better way to do this, we should discuss. |
NDS-975: Updated POM for Maven Central sync requirements
NDS-975: Added license/developer info to POM
Note the package for the new framework is edu.gslis.scoring (as opposed to edu.gslis.docscoring for the existing scorers) to allow us to maintain the old scorers for backwards compatibility but keep the new scorers distinct.
…into scoring-lib Conflicts: pom.xml
added 6 commits
August 2, 2017 14:42
Two queries are equal if they have the same title; maybe not a good choice?
Open
added 7 commits
October 17, 2017 14:00
- Revert to not saving FeatureVector by default when querying - Remove SoftReferences for storing FeatureVectors in IndexBackedSearchHits
- StandardRM1Builder now:
- Does not enforce DocScorer type
- Creates DocScorers lazily (when buildRelevanceModel is called)
- Creates the QueryScorer only once
- RM3Builder now:
- Can be built with a pre-computed RM1 vector
…o garrick Conflicts: src/main/java/edu/gslis/indexes/IndexWrapperLuceneImpl.java src/main/java/edu/gslis/searchhits/IndexBackedSearchHit.java
It turns out the IndexWrapperIndriImpl returns -1 if a docno isn't found. This was causing crashes when fetching the feature vector for unknown documents. These slight adjustments fix crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains miscellaneous improvements from independent work. Highlights:
IndexBackedSearchHits areSearchHits that know their source index so that details like docno etc. can be looked up rather than returning nulls and causing problemsIterableand addingequals()andhashCode()methods