Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addTerm(String, double) to respect stoplist #13

Merged

Conversation

bodom0015
Copy link
Contributor

  • FeatureVector#addTerm(String term, double weight) should now respect the stoplist

@gtsherman
Copy link
Contributor

We discussed earlier that this PR is a good idea. Other things to think about with FeatureVector for discussion with @craig-willis:

  • setTerm is rarely used in client code -- maybe change to protected?
  • More importantly, setTerm has a bug in that the feature length is updated by adding the new weight without first subtracting its old weight
  • The clarity method is perhaps better housed somewhere else
  • It can be confusing which feature receives the weight in the interpolate method, though I have no immediate suggestions for fixing
  • Also within the interpolate method, is it really the right thing to do to ignore mixing weights outside of [0, 1]?
  • The main method should probably be killed

@craig-willis craig-willis merged commit b915d33 into uiucGSLIS:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants