Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why are we getting negative volumes back from the imprint step #2

Open
smason opened this issue Sep 30, 2021 · 2 comments · Fixed by #23
Open

why are we getting negative volumes back from the imprint step #2

smason opened this issue Sep 30, 2021 · 2 comments · Fixed by #23

Comments

@smason
Copy link
Contributor

smason commented Sep 30, 2021

For example solid 19 from Helen's step file basically disappears and it would be good to know why. For example is it a problem with the input geometry or something to do with how I'm using OCCT.
@smason
Copy link
Contributor Author

smason commented Dec 9, 2021

also seen in Colin's data:

  • M31202405_A.8.stp

@smason smason linked a pull request Feb 1, 2022 that will close this issue
do something sensible when opencasde returns negative volumes #23
Merged
@smason
Copy link
Contributor Author

smason commented Feb 1, 2022

#23 fixes issues seen by the STEP project and a few of Colin's files (e.g. M35102552_H.2.brep and M36100110_A.brep).

unfortunately M31202405_A.8.stp still seems to fail when classifying, due to the CUT operation returning a large negative volume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do something sensible when opencasde returns negative volumes ukaea/overlap_checker
1 participant
@smason