You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem: if someone crafts a non-standard tx using the nth tx pub key (where n > 1), then the Seraphis wallet lib wouldn't identify any receives in the tx but wallet2 would.
The proposed fix: the Seraphis lib could scan using all tx pub keys in tx extra.
When the first additional pub keys vector in tx extra has unequal number of pub keys than there are enotes in the tx:
wallet2 generates derivations for each additional pub key, and will then ignore those additional pub keys beyond the number of enotes in the tx and scan the tx normally.
The problem: if someone crafts a non-standard tx that includes an unequal additional pub keys than enotes in a tx, then the Seraphis wallet lib wouldn't identify any receives in the tx but wallet2 would.
The proposed fix: if there are more additional pub keys than enotes, the Seraphis lib could ignore the additional pub keys beyond the number of enotes in a tx. If there are fewer additional pub keys than enotes the Seraphis lib could just scan using additionals corresponding to the lower indexed enotes.
The text was updated successfully, but these errors were encountered:
j-berman
added a commit
to j-berman/serai
that referenced
this issue
Jan 9, 2024
When there is >1 tx pub key included in tx extra:
When the first additional pub keys vector in tx extra has unequal number of pub keys than there are enotes in the tx:
The text was updated successfully, but these errors were encountered: