Fix ci win #526
Closed
Fix ci win #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dominik Kutra <k-dominik@users.noreply.github.com>
build will fail otherwise would probably better to fix such that also vigranumpy tests are not build with BUILD_TESTS=OFF
this will indirectly force 14.1 toolset when building, otherwise there is a standing issue with 14.2 (VS2019). xref: ref: ukoethe#525
|
Yes. Feel free to push the necessary changes to 514. If possible the git history would "make sense" |
|
I cherry picked and folded into #514 lets see how far we go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.