Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midi.file -> midi.track -> midi.event2note do not reproduce 'note off' message in midi file #175

Closed
dalehh opened this issue Sep 18, 2022 · 8 comments
Assignees
Labels
Milestone

Comments

@dalehh
Copy link

dalehh commented Sep 18, 2022

In its current form & complying with the help file structure for playing back MIDI files it appears that note off messages (note messages with a velocity of 0) are not reproduced on file playback. This results in notes hanging indefinitely and just building up as more notes are triggered.

@uliss uliss self-assigned this Sep 18, 2022
@uliss
Copy link
Owner

uliss commented Sep 19, 2022

Obviously, documentation should be improved and we should add sounding example with fluid~ synth.
But if you print [midi.event2note] to Pd window, there are notes off.

Could you attach the MIDI file you have problems with?

@dalehh
Copy link
Author

dalehh commented Sep 19, 2022

Hi - thanks for the response! I'm currently printing the event2note output to the PD window as well as using a MIDI bus monitoring tool and I can confirm that I'm only seeing note on messages, but no note off messages.

To add context - I was previously using cyclone.seq to play my MIDI files and was getting both note on and off messages, using pd vanilla 0.52 + cyclone and ceammc. Due to compatibility issues now that I transitioned an M1 Mac the only way I could get ceammc to work was with the bundled PD + ceammc distro rather than vanilla. As cyclone requires pd 0.52, I've had to abandon it and am now trying to get midi file playback to work just using ceammc.

I've attached an example file here, but I am experiencing the lack of note off messages with all my midi files.
vocal_harm_c2.mid.zip

@uliss uliss added the bug label Sep 19, 2022
@uliss uliss added this to the 0.9.5 milestone Sep 19, 2022
@uliss
Copy link
Owner

uliss commented Sep 19, 2022

Tried you file - it is valid, but uncommon:

here is output of mftext:

Note on, chan=4 pitch=62 vol=100
Time=2250  Note off, chan=4 pitch=62 vol=64
Time=2254  Note on, chan=4 pitch=64 vol=100
Time=5245  Note on, chan=4 pitch=60 vol=100
Time=5255  Note off, chan=4 pitch=64 vol=64
Time=5876  Note off, chan=4 pitch=60 vol=64

There are NoteOff messages with velocity 64. I can fix this by forcing NoteOff velocity to 0.

uliss added a commit that referenced this issue Sep 19, 2022
@dalehh
Copy link
Author

dalehh commented Sep 20, 2022

Interesting - I wonder why it's like that. I generated my files with Logic Pro X and I can't find any reference to controlling the note off volume. That fix would work though, thanks!

@uliss
Copy link
Owner

uliss commented Sep 20, 2022

You can try this version:

https://disk.yandex.ru/d/FUY_9_2m89LUZA

@dalehh
Copy link
Author

dalehh commented Sep 20, 2022 via email

@dalehh
Copy link
Author

dalehh commented Dec 30, 2022 via email

@uliss
Copy link
Owner

uliss commented Feb 6, 2023

Is it possible to install CEAMMC as an external library on PD vanilla 0.52 or greater? I have not had success with that so far but if so, it would resolve my compatibility issues. Thanks

The new release is available at github and deken. It should work with PureData 0.52, 0.53
https://github.com/uliss/pure-data/releases/tag/v2023.02

@uliss uliss closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants