Close the cli prompt when connection disconnects #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakebyrnes
force-pushed
the
close-prompt
branch
from
fbc431f
to
3da1631
Compare
calebjclark
reviewed
Sep 10, 2021
| @@ -35,7 +35,9 @@ export default class CoreSessions { | |||
| public stop(closeError: Error): boolean { | |||
| const hasSessions = this.sessionsById.size > 0; | |||
| this.queue.stop(closeError); | |||
| this.sessionsById.clear(); | |||
| for (const session of this.sessionsById.values()) { | |||
| session.close().catch(); | |||
There was a problem hiding this comment.
Lint: Promise.catch() requires 1 argument, but received 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server disconnected (ie, you kill ChromeAlive), the cli would stay up