You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for this proposal, I think that this kind of module is indeed a good idea !
Maybe you could call this script external_script ? I have a few remarks wrt your code :
1 second cache_timeout is a bit short and would hammer machines, maybe a default of 15 would be better
output_color could be called color, sounds simpler
make sure it runs with both python2 and python3 please and that it is PEP8 compliant
defaulting to whoami script sounds weird since there already is a whoami module available :) maybe provide no default and handle this properly on the code ?
OK, here is external_script, everything should work and be ready to go ;-)
The only one problem is line 31, that is too long (PEP8). I don't know how to make it shorter.
Hope you like it.
frimdo
changed the title
New module
New module - external_script
Jun 22, 2015
I have written a new module. Do you want to add it to yours?
https://gist.github.com/frimdo/804b7d8737a0fe2ffcaa
The text was updated successfully, but these errors were encountered: