Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module - external_script #104

Closed
frimdo opened this issue Jun 20, 2015 · 3 comments
Closed

New module - external_script #104

frimdo opened this issue Jun 20, 2015 · 3 comments
Assignees
Labels
enhancement 😍 I have created an enhancement

Comments

@frimdo
Copy link
Contributor

frimdo commented Jun 20, 2015

I have written a new module. Do you want to add it to yours?
https://gist.github.com/frimdo/804b7d8737a0fe2ffcaa

@ultrabug ultrabug self-assigned this Jun 22, 2015
@ultrabug ultrabug added the enhancement 😍 I have created an enhancement label Jun 22, 2015
@ultrabug
Copy link
Owner

Hi @frimdo

Thanks for this proposal, I think that this kind of module is indeed a good idea !

Maybe you could call this script external_script ? I have a few remarks wrt your code :

  • 1 second cache_timeout is a bit short and would hammer machines, maybe a default of 15 would be better
  • output_color could be called color, sounds simpler
  • make sure it runs with both python2 and python3 please and that it is PEP8 compliant
  • defaulting to whoami script sounds weird since there already is a whoami module available :) maybe provide no default and handle this properly on the code ?

@frimdo
Copy link
Contributor Author

frimdo commented Jun 22, 2015

OK, here is external_script, everything should work and be ready to go ;-)
The only one problem is line 31, that is too long (PEP8). I don't know how to make it shorter.
Hope you like it.

@frimdo frimdo changed the title New module New module - external_script Jun 22, 2015
@ultrabug
Copy link
Owner

this module was added in your PR, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 😍 I have created an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants