Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pydbus #2192

Closed
lasers opened this issue Jun 2, 2023 · 5 comments
Closed

Drop pydbus #2192

lasers opened this issue Jun 2, 2023 · 5 comments

Comments

@lasers
Copy link
Contributor

lasers commented Jun 2, 2023

Describe the bug

  1. Modules using pydbus mean py3status can't be used on faster Python3.11

Python 3.11 is between 10-60% faster than Python 3.10. On average, we measured a 1.25x speedup on the standard benchmark suite.

  1. https://github.com/LEW21/pydbus 's last commit was May 6, 2008.... More than 15 years ago.

  2. Python 3.11 changed the inspect code.

Additional context

Inspect the changed inspect - https://docs.python.org/3.13/whatsnew/3.11.html#removed

git grep -Iri 'inspect'
  pydbus/_inspect3.py:from inspect import getargspec
  pydbus/exitable.py:import inspect
  pydbus/exitable.py:             inspect.getcallargs(cb, exc_type, exc_value, traceback)
  pydbus/proxy_method.py: from inspect import Signature, Parameter
  pydbus/proxy_method.py: from ._inspect3 import Signature, Parameter
  pydbus/registration.py: from inspect import signature, Parameter
  pydbus/registration.py: from ._inspect3 import signature, Parameter

Your py3status version

This issue is for all py3status versions on python 3.11+.

Modules

git grep -Iri 'from pydbus'
  backlight.py:    from pydbus import SystemBus
  kdeconnector.py:from pydbus import SessionBus
  systemd.py:from pydbus import SessionBus, SystemBus
  vpn_status.py:from pydbus import SystemBus
  wwan.py:from pydbus import SystemBus
@ultrabug
Copy link
Owner

ultrabug commented Jun 5, 2023

You're right, I should move those modules to pure dbus like the spotify module.

@lasers
Copy link
Contributor Author

lasers commented Jun 5, 2023

This looks cool. Maybe it can work too. https://github.com/systemd/pystemd (Edit: systemd.py module).

@lasers lasers changed the title Drop pydbus from all modules Drop pydbus Jun 7, 2023
@lasers
Copy link
Contributor Author

lasers commented Jun 18, 2023

I can bring #1554 back to address systemd or is it still too much format magic? Lol.

@lasers
Copy link
Contributor Author

lasers commented Oct 10, 2024

@valdur55 can fix kdeconnector.py and wwan.py?

@valdur55
Copy link
Contributor

Looks like I have skill to do it, because mpris already uses same target dbus package.
Started with kdeconnector first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants