-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more options (general volume, preview volume, ...) #90
Comments
Indeed, the game should have more settings where required. In general, we should aim for not adding too many settings, and thus look at the use cases where extra settings would be required. For what use case would a user need a general volume control in the game settings? Doesn't every device already have its own system volume control exactly for that? |
On a second thought, you could be right. Windows lets you control the volume for every app I think. |
What could be added as well is an option to toggle the background music (that is played in the menu). |
I will close this issue now. Other options (such as background music) can be added as needed |
Actual behaviour
The SoundOptionsScene are empty and also some other options are missing.
Expected behaviour
There should be options for the general volume and preview volume.
Note that at the moment there is no song preview (see #89) but the option can be prepared nonetheless.
It would also be nice to have some options for the SingScene. For example, debug options to enable / disable the grid of beats and lyrics on the notes.
Maybe the debug options do not need an in-game UI. It could be sufficient to enable them in the Settings.json file.
The text was updated successfully, but these errors were encountered: