Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Love 11.2 Issues #25

Closed
MutableLoss opened this issue Mar 9, 2019 · 3 comments
Closed

Love 11.2 Issues #25

MutableLoss opened this issue Mar 9, 2019 · 3 comments

Comments

@MutableLoss
Copy link
Contributor

I ran into a few issues with love 11, and thought you would like to know.

Current version doesn't support the stencil update. This can be remedied by updating the setCanvas calls to include the new stencil key addition:

e.g. push.lua:83

return love.graphics.setCanvas { self:getCanvasTable(name).canvas, stencil = true }

I made the same addition to the remaining calls

While I haven't had any issues after this update, I am new to Love and I'm not if there are potential side-effects that they may cause.

The other issue is that getDPIScale on a retina screen is throwing the scaling off (guessing it's returning 4), setting the canvas to scale 25% of the intended size. To get around this, I had to change line 101:

self._PSCALE = self._highdpi and 1 -- love.window.getDPIScale() or 1

Anyways, loving the library (no pun intended)! 👍

@Ulydev
Copy link
Owner

Ulydev commented Jun 16, 2019

Hello @3desprit, thank you for opening an issue, and sorry for the delay! There is a lot of stuff going on and I don't have much time to check on all of these since I don't use LÖVE much anymore. If you have managed to fix these for your own project, I highly encourage you to contribute to the library and open a pull request, which I'll gladly review. Cheers! :-)

@MutableLoss
Copy link
Contributor Author

MutableLoss commented Jun 19, 2019

Sounds good man! I'll get a PR made this week with an update. 👍

EDIT: Or next week. 😄

@Ulydev
Copy link
Owner

Ulydev commented Jul 3, 2019

Thanks again for the PR!

@Ulydev Ulydev closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants