-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search result in tree doesn't respect filter css class #13337
Comments
Hi there @bjarnef! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @bjarnef, thanks for reporting! |
Hi @Zeegaan It can be anywhere. In this case it was in a property editor, but could be in any dashboard or other custom view. E.g. a button to trigger the function, which open the infinite editor. You could also just modify this |
@bjarnef I might need a little bit more handholding here, my contentpicker.controller $scope.openCurrentPicker now looks like this:
What do i now do in the backoffice to replicate the issue 🤔 |
If you add Depending on this nodes should be greyed... but on search these would still be selectable. |
My $scope.openCurrentPicker function:
|
Strange I think it should filter based on name as I recall. |
@bjarnef Really strange indeed, could you reproduce this behavior with my code ? 🤔 |
@Zeegaan I noticed when expanding tree to products I get but for Home Page entity I get I would have expected each item to have same structure, I think it had in past. |
However this example dashboard works - just unzip to chrome_cEXfNmxcko.mp4It also seem the search filter doesn't return results of other types now. |
@bjarnef Hmm strange indeed, it should still show stuff greyed out 😅 Seems like an issue to me! |
@Zeegaan could you try with the test dashboard attached here #13337 (comment) and the default starter kit. When filtering "home" I also get that node in filter function, but excluded since its alias is not However this issue was reported in v10.2.1, where it seemed the filter still returned the results, maybe because I only had |
@bjarnef Same for me: |
@Zeegaan I think the meta data here is just set as dictionary, so I think it hasn't been consistent between entity types. |
@bjarnef I think you are right, but I'm having a hard time following what the issue is here 🤔 So can you clarify what is the issue here? 🤔
|
@Zeegaan in the project I am working on using v10.3.2 when implementing the picker it was limited to a specific entity type, but on search I could e.g. search home page node and select that. However at that time the project was on 10.2.1 and has been updated to 10.3.2 since then. When I now test again using this:
or this:
it seems I can't reproduce it as I only get filtered results of type Maybe something else fixed that. |
@bjarnef Makes sense, so is it okay to close this then ? 😁 |
Yes, let's close this for now 😁 |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
10.2.1
Bug summary
When using
treepicker
infinite editor it is possible the usefilterCssClass
:For example:
In this example tree nodes with children are not allowed to select (only the ones without children).
However when searching in search input, it is possible to select these nodes anyway.
Specifics
No response
Steps to reproduce
Use treepicker infinite editor with
filterCssClass
property andfilter
function and notice than when search it is possible to select the nodes even though then should not be allowed to select.Expected result / actual result
No response
The text was updated successfully, but these errors were encountered: